Skip to content

Fix for invalid JSON if image label contains HTML markup, example " #17848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jeroenschipper
Copy link
Contributor

@jeroenschipper jeroenschipper commented Aug 29, 2018

Description

We experienced an issue with invalid JSON in the adminhtml when an image label contains html markup (example "). This resulted in an error when opening the images and videos tab when editing an product.

Fixed Issues (if relevant)

  1. I do not know any current issues for this problem

Manual testing scenarios

  1. add a new image to an product in the adminhtml with an label containing " " "
  2. save the product
  3. check if you can open your images and video tab in the adminhtml

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @jeroenschipper. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Contributor

@nuzil nuzil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution

@magento-engcom-team
Copy link
Contributor

Hi @nuzil, thank you for the review.
ENGCOM-2910 has been created to process this Pull Request

@jeroenschipper
Copy link
Contributor Author

Hi @nuzil and @magento-engcom-team,

Glad to help!

@magento-engcom-team magento-engcom-team merged commit f185393 into magento:2.3-develop Sep 11, 2018
@magento-engcom-team
Copy link
Contributor

Hi @jeroenschipper. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants