Skip to content

[2.3] changed intval($val) to (int) $val, since (int) $val is faster. #17946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2018
Merged

[2.3] changed intval($val) to (int) $val, since (int) $val is faster. #17946

merged 1 commit into from
Sep 11, 2018

Conversation

TBlindaruk
Copy link
Member

[2.3] changed intval($val) to (int) $val, since (int) $val is faster.

@magento-engcom-team
Copy link
Contributor

Hi @TBlindaruk. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@TBlindaruk TBlindaruk force-pushed the changed_intval_to_int_casting branch 2 times, most recently from 4b73c06 to 0372245 Compare September 5, 2018 21:34
@TBlindaruk TBlindaruk force-pushed the changed_intval_to_int_casting branch from 0372245 to de08a7b Compare September 5, 2018 21:37
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Sep 6, 2018
@magento-engcom-team magento-engcom-team merged commit de08a7b into magento:2.3-develop Sep 11, 2018
magento-engcom-team pushed a commit that referenced this pull request Sep 11, 2018
ENGCOM-2927: [2.3] changed intval($val) to (int) $val, since `(int) $…
872e489 
…val ` is faster. #17946
@magento-engcom-team
Copy link
Contributor

Hi @TBlindaruk. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sidolov sidolov

Labels
Component: Backend Component: Backup Component: Bundle Component: Catalog Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@TBlindaruk @magento-engcom-team @sidolov