Skip to content

Backend: add missing unit test for ModuleService class #18546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 22, 2018
Merged

Backend: add missing unit test for ModuleService class #18546

merged 3 commits into from
Oct 22, 2018

Conversation

dmytro-ch
Copy link
Contributor

Description

This PR adds missing unit tests for Module List Service class:

  • \Magento\Backend\Service\V1\ModuleService

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmytro-ch dmytro-ch requested a review from rogyar October 12, 2018 06:23
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Component: Backend Release Line: 2.3 labels Oct 12, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 12, 2018
rogyar
rogyar requested changes Oct 12, 2018
View reviewed changes
app/code/Magento/Backend/Test/Unit/Service/V1/ModuleServiceTest.php Outdated
*/
declare(strict_types=1);

namespace Magento\Backend\Test\Unit\Model;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, adjust the namespace to correspond the file path

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rogyar thank you!
I've updated the namespace.

@ishakhsuvarov
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @ishakhsuvarov. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @ishakhsuvarov, here is your new Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/pr-18546//admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-3167 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 7e56ae6 into magento:2.3-develop Oct 22, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 22, 2018
ENGCOM-3167: Backend: add missing unit test for ModuleService class #…
914be61 
…18546
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

1 similar comment
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

This was referenced Oct 23, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

Labels
Component: Backend Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@dmytro-ch @ishakhsuvarov @magento-engcom-team @rogyar