Skip to content

Allow set billing information via API with existing address #18704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2018

Conversation

pmclain
Copy link
Contributor

@pmclain pmclain commented Oct 19, 2018

Description (*)

Not setting the customerId with an existing address caused a
NoSuchEntityException to be thrown during address validation

}, $this->customerRepository->getById($addressData->getCustomerId())->getAddresses());

Fixed Issues (if relevant)

  1. Adding billing information via mine API expects costumer id #17485 Adding billing information via mine API expects costumer id

Manual testing scenarios (*)

  1. Create Customer token and a quote with items that would be used to add shipping and billing information
  2. A saved customer address .
  3. Hit the products REST api rest/V1/carts/mine/billing-address with generated customer token in above state with a similar body as below
{
"address": {
      "customerAddressId":"{{ saved customer address id }}",
      "countryId":"MY",
      "regionId":"572",
      "regionCode":"MLK",
      "region":"Melaka",
      "street":[  
         "My home Any Floor, any Tower ,",
         "Unknown  Road"
      ],
      "telephone":"",
      "postcode":"12345",
      "city":"Melaka",
      "firstname":"Vishwas",
      "lastname":"Bhatnagar"
   }
}
  1. Success and Returns quote address id

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @pmclain. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 19, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3226 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @pmclain. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants