Skip to content

Add a module manager to the Magento Framework API #18748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 11, 2019
Merged

Add a module manager to the Magento Framework API #18748

merged 7 commits into from
Jun 11, 2019

Conversation

navarr
Copy link
Member

@navarr navarr commented Oct 22, 2018

This is a useful addition for feature detection and enablement for third party modules (such as "activate this functionality if such and such GiftCard extension exists"

This is an update to PR #12677 to be based on 2.3

@magento-engcom-team
Copy link
Contributor

Hi @navarr. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@navarr
Copy link
Member Author

navarr commented Oct 22, 2018

#squashtoberfest

aleron75
aleron75 previously requested changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@aleron75 aleron75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are encouraged to use strict typing. Thus, I suggest adding parameter type and return value for the isEnabled() method.

@aleron75 aleron75 self-assigned this Oct 23, 2018
@navarr navarr dismissed aleron75’s stale review October 23, 2018 11:58

Added strict_types declaration to Manager.php, and added parameter and return typehints to isEnabled method

aleron75
aleron75 approved these changes Oct 24, 2018
View reviewed changes
Copy link
Contributor

@aleron75 aleron75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 24, 2018
@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-3260 has been created to process this Pull Request

@okorshenko okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019
@sivaschenko sivaschenko mentioned this pull request May 23, 2019
Closed
@sivaschenko
Copy link
Member

@Nvarr we would like to discuss this pull request on the public architecture discussion meeting on May 29, it would be great if you can join and present the solution

@navarr
Copy link
Member Author

navarr commented May 23, 2019

@sivaschenko Alright. I typically attend so that shouldn't be an issue.

@navarr
Remove API annotation from ModuleManagerInterface
6dd254b 
API Annotation should be added to the interface in Magento 2.4
@sivaschenko
Copy link
Member

Pull request was approved to be merged to 2.3-develop at Public Architectural Discussion meeting magento/architecture#165 (comment)

@ghost ghost assigned sivaschenko May 29, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3260 has been created to process this Pull Request

@soleksii soleksii self-assigned this May 31, 2019
@Nazar65 Nazar65 force-pushed the module-manager-interface branch from 88675ba to 22bed61 Compare June 3, 2019 13:39
@Nazar65 Nazar65 force-pushed the module-manager-interface branch from 22bed61 to 1f9ab52 Compare June 3, 2019 13:51
@Nazar65 Nazar65 force-pushed the module-manager-interface branch from 1f9ab52 to 4a0e862 Compare June 3, 2019 14:33
@Nazar65 Nazar65 force-pushed the module-manager-interface branch from 4a0e862 to 20f0c16 Compare June 4, 2019 07:34
@Nazar65 Nazar65 force-pushed the module-manager-interface branch from 20f0c16 to 6a3c90e Compare June 4, 2019 07:36
@Nazar65 Nazar65 force-pushed the module-manager-interface branch from 6a3c90e to 5e14e8a Compare June 4, 2019 08:06
@magento-engcom-team magento-engcom-team merged commit 5e14e8a into magento:2.3-develop Jun 11, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jun 11, 2019

Hi @navarr, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this pull request Jun 11, 2019
@sivaschenko
ENGCOM-3260: Add a module manager to the Magento Framework API magent…
7a7b7f7 
…o#18748
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleron75 aleron75 aleron75 approved these changes

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@aleron75 aleron75

@sivaschenko sivaschenko

@Nazar65 Nazar65

@soleksii soleksii

Labels
Component: Analytics Component: Backend Component: Bundle Component: Catalog Component: CatalogSearch Partner: Mediotype partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.3
Development

Successfully merging this pull request may close these issues.
9 participants
@navarr @magento-engcom-team @sivaschenko @soleksii @aleron75 @Nazar65 @okorshenko @sidolov @p-bystritsky