Skip to content

[Backport] [BUGFIX] [issue-10205] Always set the entity_type_id for updating pro #18867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

gelanivishal
Copy link
Contributor

@gelanivishal gelanivishal commented Oct 27, 2018

Original PR

#18622

…duct attributes because the route contains the specification products/attributes

Description (*)

issue description which is solved:

Using Magento 2.1.7 with the REST API - POST /V1/products/attributes - I can add a new attribute and configure it with settings such as is_filterable.

This is all fine but if I then want to change this setting I can't. I have tried with POST and with PUT /V1/products/attributes/{attributeCode}. The command works as in it will update, for instance, the frontend label in the eav_attribute table, but it does not seem to have any effect on values in the catalog_eav_attribute table.

Fixed Issues (if relevant)

  1. REST API /V1/products/attributes does not update all properties #10205: REST API /V1/products/attributes does not update all properties

Manual testing scenarios (*)

  1. Add a new attribute using REST API - POST - /V1/products/attributes - with is_filterable set to false.
  2. Update the same attribute using either the same POST url or PUT - /V1/products/attributes/{attributeCode} and set the is_filterable field to true
  3. Result: attribute is not set to is_filterable
  4. Apply changes
  5. Update the same attribute using either the same POST url or PUT - /V1/products/attributes/{attributeCode} and set the is_filterable field to true
  6. Result: attribute is set to is_filterable

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov
Copy link
Contributor

sidolov commented Oct 31, 2018

Hi @gelanivishal , changes in original PR are different and should be adopted for the current version.

@gelanivishal
Copy link
Contributor Author

@sidolov Please check changes.

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Nov 1, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3363 has been created to process this Pull Request

@sidolov
Copy link
Contributor

sidolov commented Nov 5, 2018

Hi @gelanivishal , unfortunately, we can not reproduce the described issue on the 2.2-develop, maybe you can provide additional steps?
Thank you!

@gelanivishal
Copy link
Contributor Author

@sidolov I don't have additional steps.

@sidolov
Copy link
Contributor

sidolov commented Nov 18, 2018

@gelanivishal , in such case I'm closing this PR as not relevant.
Thank you for your contribution!

@sidolov sidolov closed this Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants