Skip to content

12183 Fixed Configurable Product's normal price is not visible on Product Catalog #18883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

krnshah
Copy link
Contributor

@krnshah krnshah commented Oct 27, 2018

Description (*)

Fixed Configurable Product's normal price is not visible on Product Catalog

Fixed Issues (if relevant)

  1. Configurable Product's normal price is not visible on Product Catalog #12183: Fixed Configurable Product's normal price is not visible on Product Catalog

Manual testing scenarios (*)

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 27, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @krnshah. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Oct 28, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3309 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@krnshah thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@VladimirZaets
Copy link
Contributor

Hi @krnshah, thanks for collaboration. We tried to apply your fix, but regular price for products still not showing.

@VladimirZaets
Copy link
Contributor

Hi @krnshah , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for collaboration

@krnshah
Copy link
Contributor Author

krnshah commented Nov 24, 2018

Hi @VladimirZaets

Step to reproduce the bug :

-- Create configurable product and assign 2 or 3 simple products.
-- Set special price to the simple product. that lowest special price from configurable product should be shown in product listing page as As low as price and there should be shown regular price of that same product as well (you can see the simple product).

-- Expected result :
2

-- Actual result :
screenshot-10 16 16 93-2018 11 24-11-12-51

@krnshah
Copy link
Contributor Author

krnshah commented Nov 24, 2018

As per the PR i have changed in app/code/Magento/ConfigurableProduct/view/base/templates/product/price/final_price.phtml this file.
-- There is one condition to check isProductList from product data. and it will set false statically so i have remove that condition (we dont need to check that condition for configurable product).
-- And set the value of is_product_list in an array so this will achieve our expected result.

@sidolov
Copy link
Contributor

sidolov commented Jan 28, 2019

Hi @krnshah , changeset for current PR does not contain any changes.
I'm closing this PR right now. Please, update the branch and reopen it if you wish to continue.
Thank you!

@sidolov sidolov closed this Jan 28, 2019
@ghost
Copy link

ghost commented Jan 28, 2019

Hi @krnshah, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sidolov sidolov self-assigned this Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants