Skip to content

Fixed : 18919 fixed magnifier issue #18921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

krnshah
Copy link
Contributor

@krnshah krnshah commented Oct 29, 2018

Description (*)

Fixed magnifier issue on product catalog page.

Fixed Issues (if relevant)

  1. Magento catalog product page gallery hide magnifier when mouse leave. #18919: Magento catalog product page gallery hide magnifier when mouse leave.
  2. ...

Manual testing scenarios (*)

  1. N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @krnshah. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@krnshah krnshah self-assigned this Oct 29, 2018
@krnshah krnshah requested review from abrarpathan19 and removed request for rostyslav-hymon and abrarpathan19 October 29, 2018 10:14
@gwharton
Copy link
Contributor

Already fixed

2.3
#18702

2.2
c55480e#diff-a3d63022f922ef08dd75e31dddb0025a

@gwharton gwharton closed this Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants