Correct location of transparent.js #19764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reference to this file was originally changed: magento@0ce439b#diff-7fec090bf536a50e1bdfa20e039e27edR9 magento@0ce439b#diff-6de82c32cd46b3be45d4d65e403f4136R9 And the file was moved here: magento@0ce439b#diff-b0845d35ccdd892fe5e1a93a9b714b66 The file move was not ported to 2.3 but the requirejs-config was, breaking admin sales order create with PayflowPro and Authorize.net Fixes magento#19763
|
Hi @pmclain. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
magento-engcom-team
added
Area: Frontend
Component: Payment
Release Line: 2.3
Partner: Something Digital
partners-contribution
pmclain
added a commit
to pmclain/magento2
that referenced
this pull request
Dec 14, 2018
This sets the token `isVisible` value to faluse if `VaultConfigProvider::IS_ACTIVE_CODE` is not set in the payment's `additionalInformation` property. The value is not set when placing orders through the admin panel, unless the save for later checkbox is selected. This caused all admin order payment to be visible in the stored payment method section in the storefront. Fixes magento#19515 Testing on 2.3 depends on magento#19764
4 tasks
VladimirZaets
approved these changes
Dec 14, 2018
|
Hi @VladimirZaets, thank you for the review. |
|
Hi @pmclain. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
The reference to this file was originally changed:
0ce439b#diff-7fec090bf536a50e1bdfa20e039e27edR9
0ce439b#diff-6de82c32cd46b3be45d4d65e403f4136R9
And the file was moved here:
0ce439b#diff-b0845d35ccdd892fe5e1a93a9b714b66
The file move was not ported to 2.3 but the requirejs-config was, breaking
admin sales order create with PayflowPro and Authorize.net
Fixed Issues (if relevant)
Manual testing scenarios (*)
adminhtml/Magento/backend/{{locale}}/Magento_Payment/js/transparent.jsshould not return a 404 error.Contribution checklist (*)