Skip to content

Update file-uploader.js #19999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update file-uploader.js #19999

wants to merge 1 commit into from

Conversation

flancer64
Copy link
Contributor

To prevent error

file-uploader.js:173 Uncaught ReferenceError: Base64 is not defined
    at UiClass.processFile (file-uploader.js:173)
    ...

at "Admin / Content / Design / Configuration / Edit (any item)"

image

Description (*)

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title
  2. ...

Manual testing scenarios (*)

  1. ...
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

To prevent error
```
file-uploader.js:173 Uncaught ReferenceError: Base64 is not defined
    at UiClass.processFile (file-uploader.js:173)
    ...
```

at "Admin / Content / Design / Configuration / Edit (any item)"
@magento-engcom-team
Copy link
Contributor

Hi @flancer64. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@Nazar65
Copy link
Member

Nazar65 commented Dec 28, 2018

Hi @flancer64 this is duplicate #19988

@flancer64
Copy link
Contributor Author

Thanks, @Nazar65 (y)

@flancer64 flancer64 closed this Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants