Skip to content

2.3 develop ddevesh typos fixed #20039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 16, 2019
Merged

2.3 develop ddevesh typos fixed #20039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae9daab
typos error fixed
ddevesh Jan 2, 2019
6299405
typo error fixed
ddevesh Jan 2, 2019
b0cd9b7
typo-error-fixed-trailing@63
ddevesh Jan 2, 2019
fd1a404
typo-error-fixed-Retrieve@325
ddevesh Jan 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Related.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ protected function _prepareColumns()
}

/**
* Rerieve grid URL
* Retrieve grid URL
*
* @return string
*/
Expand Down
6 changes: 3 additions & 3 deletions app/code/Magento/Catalog/view/adminhtml/web/catalog/product/composite/configure.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ define([

/**
* Add product list types as scope and their urls
* expamle: addListType('product_to_add', {urlFetch: 'http://magento...'})
* expamle: addListType('wishlist', {urlSubmit: 'http://magento...'})
* example: addListType('product_to_add', {urlFetch: 'http://magento...'})
* example: addListType('wishlist', {urlSubmit: 'http://magento...'})
*
* @param type types as scope
* @param urls obj can be
Expand All @@ -112,7 +112,7 @@ define([
/**
* Adds complex list type - that is used to submit several list types at once
* Only urlSubmit is possible for this list type
* expamle: addComplexListType(['wishlist', 'product_list'], 'http://magento...')
* example: addComplexListType(['wishlist', 'product_list'], 'http://magento...')
*
* @param type types as scope
* @param urls obj can be
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Catalog/view/base/web/js/price-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ define([
pattern = pattern.indexOf('{sign}') < 0 ? s + pattern : pattern.replace('{sign}', s);

// we're avoiding the usage of to fixed, and using round instead with the e representation to address
// numbers like 1.005 = 1.01. Using ToFixed to only provide trailig zeroes in case we have a whole number
// numbers like 1.005 = 1.01. Using ToFixed to only provide trailing zeroes in case we have a whole number
i = parseInt(
amount = Number(Math.round(Math.abs(+amount || 0) + 'e+' + precision) + ('e-' + precision)),
10
Expand Down