Skip to content

12183 fix special price #20726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

12183 fix special price #20726

wants to merge 2 commits into from

Conversation

krnshah
Copy link
Contributor

@krnshah krnshah commented Jan 28, 2019 •
edited
Loading

Description (*)

Resolve the special price issue for configurable product.

Fixed Issues (if relevant)

  1. Configurable Product's normal price is not visible on Product Catalog #12183: Configurable Product's normal price is not visible on Product Catalog

Manual testing scenarios (*)

  1. N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @krnshah. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@krnshah krnshah mentioned this pull request Jan 28, 2019
Closed
4 tasks
@krnshah krnshah requested a review from sivaschenko January 28, 2019 13:19
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 28, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3994 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@krnshah thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@okorshenko okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019
@krnshah krnshah requested a review from sivaschenko February 28, 2019 04:57
@sivaschenko sivaschenko requested a review from kandy March 4, 2019 12:49
@krnshah krnshah self-assigned this Mar 6, 2019
@ghost ghost unassigned krnshah Mar 6, 2019
@ghost
Copy link

ghost commented Mar 6, 2019

@krnshah unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@sivaschenko
Copy link
Member

A performance test is required for these changes:
Category page with 50% configurable product with 1k option and 50% of bundle product with 1k option.
It can be done on a local environment with measurement of response time (just make it at least 10times) by any tools include a browser or apache benchmark.

@ghost ghost assigned orlangur Apr 4, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-3994 has been created to process this Pull Request

@p-bystritsky p-bystritsky self-assigned this Apr 5, 2019
@p-bystritsky
Copy link
Contributor

p-bystritsky commented Apr 8, 2019 •
edited
Loading

@sivaschenko
Seems like minor (7.5%) degradation is present on non-cached category pages. No degradation for cached.
Setup: category with 9 Configurable products with 1000 options each (generated with performance toolkit).
2.3 mainline branch: 1.21 minutes average page load time (10 tries).
PR branch: 1.30 minutes average page load time (10 tries).

@krnshah krnshah requested a review from orlangur April 9, 2019 10:51
orlangur
orlangur reviewed Apr 9, 2019
View reviewed changes
...ests/app/Magento/ConfigurableProduct/Test/Constraint/AssertConfigurableProductInCategory.php
\PHPUnit\Framework\Assert::assertEquals(
number_format($price, 2, '.', ''),
$priceBlock->getNormalPrice(),
'Product normal price on category page is not correct.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@p-bystritsky how is normal price different from regular price?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orlangur actual configurable product price on category page is located in span with 'normal_price' class.

@sivaschenko
Copy link
Member

Hi @krnshah ! Unfortunately, we were unable to approve the functionality and the performance implications introduced by this pull request at this time and I have to close it.

@sivaschenko sivaschenko closed this Apr 9, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 9, 2019

Hi @krnshah, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@orlangur orlangur mentioned this pull request Apr 12, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

@p-bystritsky p-bystritsky p-bystritsky left review comments

@sivaschenko sivaschenko Awaiting requested review from sivaschenko

@kandy kandy Awaiting requested review from kandy

Assignees

@orlangur orlangur

@sivaschenko sivaschenko

@p-bystritsky p-bystritsky

Labels
Area: Frontend Component: ConfigurableProduct Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: extended testing Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@krnshah @magento-engcom-team @sivaschenko @p-bystritsky @orlangur @okorshenko