-
Notifications
You must be signed in to change notification settings - Fork 9.4k
12183 fix special price #20726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12183 fix special price #20726
Conversation
Hi @krnshah. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @sivaschenko, thank you for the review. |
@krnshah unfortunately, only members of the maintainers team are allowed to assign developers to the pull request |
A performance test is required for these changes: |
Hi @orlangur, thank you for the review. |
@sivaschenko |
\PHPUnit\Framework\Assert::assertEquals( | ||
number_format($price, 2, '.', ''), | ||
$priceBlock->getNormalPrice(), | ||
'Product normal price on category page is not correct.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@p-bystritsky how is normal price different from regular price?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orlangur actual configurable product price on category page is located in span with 'normal_price' class.
Hi @krnshah ! Unfortunately, we were unable to approve the functionality and the performance implications introduced by this pull request at this time and I have to close it. |
Hi @krnshah, thank you for your contribution! |
Description (*)
Resolve the special price issue for configurable product.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)