Skip to content

Remove fotorama.min.js #22082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2019
Merged

Remove fotorama.min.js #22082

merged 1 commit into from
Apr 23, 2019

Conversation

iGerchak
Copy link
Contributor

@iGerchak iGerchak commented Apr 1, 2019

Description

Remove fotorama.min.js because it's not up to date.
For example in 563488e and 37db806 were made changes just in fotorama.js, but fotorama.min.js wasn't updated.
Also, Magento automatically creates min.js files.

@iGerchak iGerchak requested a review from ihor-sviziev April 1, 2019 09:54
@m2-assistant
Copy link

m2-assistant bot commented Apr 1, 2019

Hi @iGerchak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost ghost assigned ihor-sviziev Apr 1, 2019
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-4628 has been created to process this Pull Request

@soleksii soleksii self-assigned this Apr 4, 2019
@soleksii
Copy link

soleksii commented Apr 4, 2019

✔️ QA Passed

@nmalevanec nmalevanec self-assigned this Apr 5, 2019
@VladimirZaets VladimirZaets self-assigned this Apr 19, 2019
@soleksii
Copy link

✔️ QA Passed

@magento-engcom-team magento-engcom-team merged commit c0255a1 into magento:2.3-develop Apr 23, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 23, 2019

Hi @iGerchak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Apr 23, 2019
@sivaschenko
ENGCOM-4628: Remove fotorama.min.js #22082
44b4d13
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 23, 2019
@ihor-sviziev ihor-sviziev mentioned this pull request Jun 19, 2019
Merged
4 tasks
@torhoehn torhoehn mentioned this pull request Jul 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@VladimirZaets VladimirZaets

@nmalevanec nmalevanec

@soleksii soleksii

Labels
Area: Lib/Frontend Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
6 participants
@iGerchak @magento-engcom-team @soleksii @ihor-sviziev @VladimirZaets @nmalevanec