Attributes named like mysql reserved keywords will break flat catalog indexing

[ghost]

Description (*)

Having a product attribute named condition or some other mysql reserved keyword will result in an error while indexing flat catalog:

Ex:

SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'condition IS NOT NULL)' at line 5, query was: UPDATE catalog_product_flat_1_tmp_indexer AS et
LEFT JOIN eav_attribute_option_value AS t0 ON t0.option_id = et.condition AND t0.store_id = 0
LEFT JOIN eav_attribute_option_value AS ts ON ts.option_id = et.condition AND ts.store_id = 1
SET et.condition_value = IFNULL(ts.value, t0.value)
WHERE (condition IS NOT NULL)

Fixed Issues (if relevant)

Fixes flat catalog indexing for that scenario

1. magento/magento2#<issue_number>: Issue title
2. ...

[m2-assistant]

Hi @florinsith. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-cicd2]

All committers have signed the CLA.

[orlangur]

@florinsith any contribution should be delivered to 2.3-develop first. Is it reproducible there?

[ghost]

The 2.3-develop code is different and weird but I dont think it has an issue. By looking at the code it should result in something like:

.....
SET et.condition_value = IFNULL(ts.value, t0.value)
WHERE (IFNULL(ts.value, t0.value) IS NOT NULL)
....

As you notice the attribute code is replaced by that ifnull function in the where condition.

So I guess its just the 2.2 branch,

[orlangur]

@florinsith ok, then corresponding changes needs to be backported from 2.3-develop (as full commits) instead of custom ones applied.

[orlangur]

Closing due to inactivity. Feel free to reach me out anytime later if you wish to continue work on this pull request and it will be reopened.
Thanks for collaboration!

[m2-assistant]

Hi @florinsith, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[ghost]

I dont really understand what you mean, I am not familiar with this flow. How would I make the change on 2.3-develop since that has different code?

[orlangur]

@florinsith you need to find commits where fixed logic was introduced for 2.3-develop and cherry-pick them to 2.2-develop.