-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Backport] Resolved undefined index issue for import adapter #22180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Resolved undefined index issue for import adapter #22180
Conversation
Hi @amol2jcommerce. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @rogyar, thank you for the review. |
HI @amol2jcommerce based on this comment #19761 (comment) fix for forward port must be reverted and refactored. |
Hi @sidolov, thank you for the review. |
QA Passed ✔️ |
Hi @amol2jcommerce, thank you for your contribution! |
Original Pull Request
#19765
Description (*)
Added a condition to check if 'sku' column exists in CSV file before setting its value.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Magento\ImportExport\Model\Import\Entity\AbstractEntity
getValidColumnNames()
function.e.g. ['column1', 'column2', 'column3']
Contribution checklist (*)