Skip to content

[Backport] Fixed #22223 Missing/Wrong data display on downloadable report table … #22523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2019
Merged

[Backport] Fixed #22223 Missing/Wrong data display on downloadable report table … #22523

merged 3 commits into from
Apr 30, 2019

Conversation

shikhamis11
Copy link
Member

Original Pull Request

#22291
Fixed #22223 Missing/Wrong data display on downloadable report table reports > downloads in BO

Preconditions (*)

  1. At least Magento 2.1.11 to 2.3.1 are concerned

Steps to reproduce (*)

1.Create 22 downloadable products
2.Order the 22 downloadable products
3. Complete the order in BO
3.Visit the downloadable links to download bought products (from frontend customer account)
4 Go go downloads reports table in the backoffice at reports>downloads

Expected result (*)

  1. Should've found 22 records / products with their download count as well as a pagination

good_report_pagination_ok

Actual result (*)

  1. Only 1 records found also the table only show the first 20 products with no pagination

only_first_20_product

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 27, 2019

Hi @shikhamis11. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4834 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Apr 30, 2019

Hi @shikhamis11, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Apr 30, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants