Skip to content

#22786 Add dependency for UPS required fields to avoid validation for these fields if UPS Shipping is not active #22787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

serhiyzhovnir
Copy link

Description (*)

I have added the dependency on UPS active config for Access License Number, Password, User ID UPS configs.
It prevents validation for Access License Number, Password, User ID fields and hides them in the case when UPS is disabled.

Fixed Issues

  1. The validation for UPS configurations triggers even if UPS is disabled for checkout #22786: The validation for UPS configurations triggers even if UPS is disabled for checkout

Manual testing scenarios (*)

  1. Go to the Admin -> Stores -> Configuration -> Sales -> Shipping Methods
  2. Click on Save Config button

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…ion for these fields if UPS is not active
@m2-assistant
Copy link

m2-assistant bot commented May 8, 2019

Hi @serhiyzhovnir. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Ups Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels May 8, 2019
@serhiyzhovnir serhiyzhovnir requested a review from rogyar May 8, 2019 13:31
Serhiy Zhovnir added 2 commits May 10, 2019 13:36
…22786-fix-validation-for-UPS-configurations
…22786-fix-validation-for-UPS-configurations
@serhiyzhovnir serhiyzhovnir requested a review from dmytro-ch May 12, 2019 11:43
@dmytro-ch dmytro-ch self-assigned this May 13, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-5109 has been created to process this Pull Request

@soleksii
Copy link

✔️ QA Passed

Before:

before

After:

after

@m2-assistant
Copy link

m2-assistant bot commented May 23, 2019

Hi @serhiyzhovnir, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Ups Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants