[Fixed] Reset feature does not clear the date #23007

niravkrish · 2019-05-24T09:42:07Z

Description (*)

Form Reset feature does not clear the UI date field.
I have added code to clear date field in admin UI Forms.

Fixed Issues (if relevant)

Reset feature does not clear the date #22940: Reset feature does not clear the date

Steps to reproduce (*)

Admin > Marketing > Catalog/Cart price rule > Add New Rule > Fill all data with date > now click on reset > Review all the fields are cleared or not

Manual testing scenarios (*)

Manual Testing
I have tested this changes with described steps and it is working fine.

Expected result (*)

All fields should be blank.

Actual result (*)

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2019-05-24T09:42:09Z

Hi @niravkrish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento-engcom-team give me test instance - deploy test instance based on PR changes
@magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

magento-engcom-team · 2019-05-24T11:32:41Z

Hi @VladimirZaets, thank you for the review.
ENGCOM-5155 has been created to process this Pull Request

VasylShvorak · 2019-05-24T12:20:42Z

With PR changes date is always cleared by Reset button.
Manual testing scenario:

Create Cart price rule with date (fields From and To)
Go to Cart price rule edit page
Edit Rule Name and Description, but don't touch date
Click Reset

Result:
✔️ Rule Name and Description are reset to previous values
❌ Date fields From and To are cleared
Notice: Dates are cleared only visual. If save Cart price rule after Reset button was clicked, dates values are same as before edit
@VladimirZaets Could you you check if it is expected behavior?

orlangur · 2019-05-24T18:06:46Z

app/code/Magento/Ui/view/base/web/js/form/form.js

@@ -339,6 +339,7 @@ define([
         */
        reset: function () {
            this.source.trigger('data.reset');
+            $('._has-datepicker').val('');


Business logic must not rely on CSS classes, see Code Demarcation Standard. Please add appropriate data attributes instead.

@orlangur updated.

p-bystritsky · 2019-06-05T12:41:48Z

@orlangur please review changes.

orlangur · 2019-06-05T13:08:32Z

app/code/Magento/Ui/view/base/web/js/form/form.js

@@ -339,6 +339,7 @@ define([
         */
        reset: function () {
            this.source.trigger('data.reset');
+            $('[data-index$="_date"] input').val('');


We must not rely on input tag name. Please omit unnecessary quotes "".

@orlangur updated.

magento-engcom-team · 2019-06-06T14:22:43Z

Hi @orlangur, thank you for the review.
ENGCOM-5155 has been created to process this Pull Request

VasylShvorak · 2019-06-07T10:05:52Z

✔️ QA passed

m2-assistant · 2019-06-08T22:22:24Z

Hi @niravkrish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Fixed - Reset feature does not clear the date

c9f98fc

magento-engcom-team added Area: Frontend Component: Ui Release Line: 2.3 Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner labels May 24, 2019

VladimirZaets approved these changes May 24, 2019

View reviewed changes

ghost assigned VladimirZaets May 24, 2019

ghost added the Progress: ready for testing label May 24, 2019

VasylShvorak self-assigned this May 24, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels May 24, 2019

ghost added Progress: needs update and removed Progress: testing in progress labels May 24, 2019

orlangur requested changes May 24, 2019

View reviewed changes

ghost assigned orlangur May 24, 2019

p-bystritsky self-assigned this Jun 5, 2019

p-bystritsky removed the Progress: needs update label Jun 5, 2019

orlangur requested changes Jun 5, 2019

View reviewed changes

ghost added the Progress: needs update label Jun 5, 2019

magento#23007: Code demarcation standard fix.

40cc415

p-bystritsky force-pushed the Fixed-22940 branch from 8cb5c0d to 40cc415 Compare June 6, 2019 10:49

p-bystritsky removed the Progress: needs update label Jun 6, 2019

orlangur approved these changes Jun 6, 2019

View reviewed changes

ghost added the Progress: ready for testing label Jun 6, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels Jun 7, 2019

ghost added Progress: extended testing Progress: accept and removed Progress: testing in progress Progress: extended testing labels Jun 7, 2019

magento-engcom-team mentioned this pull request Jun 8, 2019

Reset feature does not clear the date #22940

Closed

magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this pull request Jun 8, 2019

ENGCOM-5155: [Fixed] Reset feature does not clear the date magento#23007

ce6a50a

magento-engcom-team merged commit 40cc415 into magento:2.3-develop Jun 8, 2019

magento-engcom-team added this to the Release: 2.3.3 milestone Jun 8, 2019

krnshah mentioned this pull request Jun 10, 2019

Backport reset feature does not clear the date #23187

Closed

4 tasks

krishprakash mentioned this pull request Jul 11, 2019

[Backport] [Fixed] Reset feature does not clear the date #23658

Merged

4 tasks

krishprakash pushed a commit to krishprakash/magento2 that referenced this pull request Jul 11, 2019

magento#23007: Code demarcation standard fix.

e378c79

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Fixed] Reset feature does not clear the date #23007

[Fixed] Reset feature does not clear the date #23007

Uh oh!

niravkrish commented May 24, 2019

Uh oh!

m2-assistant bot commented May 24, 2019

Uh oh!

magento-engcom-team commented May 24, 2019

Uh oh!

VasylShvorak commented May 24, 2019

Uh oh!

orlangur May 24, 2019

Uh oh!

p-bystritsky Jun 5, 2019

Uh oh!

p-bystritsky commented Jun 5, 2019

Uh oh!

orlangur Jun 5, 2019

Uh oh!

p-bystritsky Jun 6, 2019

Uh oh!

magento-engcom-team commented Jun 6, 2019

Uh oh!

VasylShvorak commented Jun 7, 2019

Uh oh!

m2-assistant bot commented Jun 8, 2019

Uh oh!

Uh oh!

[Fixed] Reset feature does not clear the date #23007

[Fixed] Reset feature does not clear the date #23007

Uh oh!

Conversation

niravkrish commented May 24, 2019

Description (*)

Fixed Issues (if relevant)

Steps to reproduce (*)

Manual testing scenarios (*)

Expected result (*)

Actual result (*)

Contribution checklist (*)

Uh oh!

m2-assistant bot commented May 24, 2019

Uh oh!

magento-engcom-team commented May 24, 2019

Uh oh!

VasylShvorak commented May 24, 2019

Uh oh!

orlangur May 24, 2019

Choose a reason for hiding this comment

Uh oh!

p-bystritsky Jun 5, 2019

Choose a reason for hiding this comment

Uh oh!

p-bystritsky commented Jun 5, 2019

Uh oh!

orlangur Jun 5, 2019

Choose a reason for hiding this comment

Uh oh!

p-bystritsky Jun 6, 2019

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Jun 6, 2019

Uh oh!

VasylShvorak commented Jun 7, 2019

Uh oh!

m2-assistant bot commented Jun 8, 2019

Uh oh!

Uh oh!