Skip to content

[Backport] Fixed issue #22875 Billing Agreements page title need to be improved #23322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

krishprakash
Copy link

Original Pull Request

#22876
Fixed #22875 Billing Agreements page title need to be improved

Preconditions (*)

  1. Magento 2.3.x
  2. Customer must be logged in.

Steps to reproduce (*)

  1. Login as customer in frontend
  2. Now go to Billing Agreements tab

Expected result (*)

1.Page title must be only : Billing Agreements

Actual result (*)

  1. Page title is showing: Billing Agreements / My Account

@m2-assistant
Copy link

m2-assistant bot commented Jun 19, 2019

Hi @krishprakash. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @krishprakash,
the changes provided by this PR are incompatible with Magento 2.2.x, because of the missing interface:

Magento/Framework/App/Action/HttpGetActionInterface

Please make sure the changes are working and compatible with the corresponding release line before creating a PR.

@krishprakash
Copy link
Author

Hi @krishprakash,
the changes provided by this PR are incompatible with Magento 2.2.x, because of the missing interface:

Magento/Framework/App/Action/HttpGetActionInterface

Please make sure the changes are working and compatible with the corresponding release line before creating a PR.
@dmytro-ch thanks for your review.
Will make sure further.

@m2-assistant
Copy link

m2-assistant bot commented Jun 19, 2019

Hi @krishprakash, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@krishprakash krishprakash deleted the 2.2-develop-PR-port-22876 branch June 19, 2019 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants