Skip to content

[2.2][Backport] Transfer Encoding of emails changed to QUOTED-PRINTABLE #23650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -685,7 +685,7 @@ public function testConfirmationEmailWithSpecialCharacters()

$this->assertContains('To: ' . $email, $rawMessage);

$content = $message->getBody()->getPartContent(0);
$content = $message->getBody()->getParts()[0]->getRawContent();
$confirmationUrl = $this->getConfirmationUrlFromMessageContent($content);
$this->setRequestInfo($confirmationUrl, 'confirm');
$this->clearCookieMessagesList();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@

namespace Magento\Newsletter\Model;

/**
* \Magento\Newsletter\Model\Subscriber tests
*/
class SubscriberTest extends \PHPUnit\Framework\TestCase
{
/**
Expand Down Expand Up @@ -39,7 +42,7 @@ public function testEmailConfirmation()
$this->assertContains(
'/newsletter/subscriber/confirm/id/' . $this->_model->getSubscriberId()
. '/code/ysayquyajua23iq29gxwu2eax2qb6gvy',
$transportBuilder->getSentMessage()->getRawMessage()
$transportBuilder->getSentMessage()->getBody()->getParts()[0]->getRawContent()
);
$this->assertEquals(Subscriber::STATUS_NOT_ACTIVE, $this->_model->getSubscriberStatus());
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ public function testSendEmailOnOrderSave()
);

$this->assertEquals($message->getSubject(), $subject);
$this->assertThat($message->getRawMessage(), $assert);
$this->assertThat($message->getBody()->getParts()[0]->getRawContent(), $assert);
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public function testSendEmailOnAddCreditmemoComment()
);

$this->assertEquals($message->getSubject(), $subject);
$this->assertThat($message->getRawMessage(), $messageConstraint);
$this->assertThat($message->getBody()->getParts()[0]->getRawContent(), $messageConstraint);
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public function testSendEmailOnCreditmemoSave()
);

$this->assertEquals($message->getSubject(), $subject);
$this->assertThat($message->getRawMessage(), $messageConstraint);
$this->assertThat($message->getBody()->getParts()[0]->getRawContent(), $messageConstraint);
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public function testSendOrderEmail()
);

$this->assertEquals($message->getSubject(), $subject);
$this->assertThat($message->getRawMessage(), $assert);
$this->assertThat($message->getBody()->getParts()[0]->getRawContent(), $assert);
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public function testSendEmailOnAddInvoiceComment()
);

$this->assertEquals($message->getSubject(), $subject);
$this->assertThat($message->getRawMessage(), $messageConstraint);
$this->assertThat($message->getBody()->getParts()[0]->getRawContent(), $messageConstraint);
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public function testSendInvoiceEmail()
);

$this->assertEquals($message->getSubject(), $subject);
$this->assertThat($message->getRawMessage(), $messageConstraint);
$this->assertThat($message->getBody()->getParts()[0]->getRawContent(), $messageConstraint);
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public function testSendEmailOnInvoiceSave()
);

$this->assertEquals($message->getSubject(), $subject);
$this->assertThat($message->getRawMessage(), $messageConstraint);
$this->assertThat($message->getBody()->getParts()[0]->getRawContent(), $messageConstraint);
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,6 @@ public function testSendEmailOnOrderPlace()
);

$this->assertEquals($message->getSubject(), $subject);
$this->assertThat($message->getRawMessage(), $assert);
$this->assertThat($message->getBody()->getParts()[0]->getRawContent(), $assert);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public function testSendEmailOnShipmentCommentAdd()
);

$this->assertEquals($message->getSubject(), $subject);
$this->assertThat($message->getRawMessage(), $messageConstraint);
$this->assertThat($message->getBody()->getParts()[0]->getRawContent(), $messageConstraint);
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public function testSendEmailOnShipmentSave()
);

$this->assertEquals($message->getSubject(), $subject);
$this->assertThat($message->getRawMessage(), $messageConstraint);
$this->assertThat($message->getBody()->getParts()[0]->getRawContent(), $messageConstraint);
}

/**
Expand Down
2 changes: 2 additions & 0 deletions lib/internal/Magento/Framework/Mail/Message.php
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,8 @@ private function createMimeFromString($body, $messageType)
{
$part = new Part($body);
$part->setCharset($this->zendMessage->getEncoding());
$part->setEncoding(Mime::ENCODING_QUOTEDPRINTABLE);
$part->setDisposition(Mime::DISPOSITION_INLINE);
$part->setType($messageType);
$mimeMessage = new \Zend\Mime\Message();
$mimeMessage->addPart($part);
Expand Down
6 changes: 4 additions & 2 deletions lib/internal/Magento/Framework/Mail/Test/Unit/MessageTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,10 @@ public function testSetBodyHtml()

$part = $this->message->getBody()->getParts()[0];
$this->assertEquals('text/html', $part->getType());
$this->assertEquals('8bit', $part->getEncoding());
$this->assertEquals('quoted-printable', $part->getEncoding());
$this->assertEquals('utf-8', $part->getCharset());
$this->assertEquals('body', $part->getContent());
$this->assertEquals('inline', $part->getDisposition());
}

public function testSetBodyText()
Expand All @@ -37,8 +38,9 @@ public function testSetBodyText()

$part = $this->message->getBody()->getParts()[0];
$this->assertEquals('text/plain', $part->getType());
$this->assertEquals('8bit', $part->getEncoding());
$this->assertEquals('quoted-printable', $part->getEncoding());
$this->assertEquals('utf-8', $part->getCharset());
$this->assertEquals('body', $part->getContent());
$this->assertEquals('inline', $part->getDisposition());
}
}