[2.2][Backport] Improve Database Media Storage Configuration settings usability

[gwharton]

Original PR

1. [2.3] Improve Database Media Storage Configuration settings usability #23710: [2.3] Improve Database Media Storage Configuration settings usability

Description (*)

The Media Storage Location setting has the option to "use default value", however this option causes issues with the page's javascript routines which need to independently control whether the media storage location dropdown box is enabled or not. This can result in situations where the use default value checkbox is checked, but the setting is enabled (and ignored). This PR removed the "Use default value" option for both the media storage mode and location.

Fixed Issues (if relevant)

1. Database Media Storage : Difficulty changing mode to database media storage due to poor "Use Default Value" checkbox behaviour #23597: Database Media Storage : Difficulty changing mode to database media storage due to poor "Use Default Value" checkbox behaviour

Manual testing scenarios (*)

1. Stores -> Configuration -> Advanced -> System -> Storage Configuration for Media
2. Ensure there is no "Use default value" checkbox next to "Media Storage" dropdown
3. Ensure "Media Storage" is enabled
4. Change mode to Database
5. Ensure there is no "Use default value" checkbox next to "Database" dropdown
6. Select "default setup" for database
7. Click Synchronize
8. Verify that both "Media Storage" and "Database" are both greyed out during the synchronization, but are re-enabled once complete.
9. Click "Save Config"
10. After screen refresh, Verify that both "Media Storage" and "Database" are both enabled and selectable.
11. Change mode to Filesystem
12. Click Synchronize
13. Verify that "Media Storage" is greyed out during the synchronization, but is re-enabled once complete.
14. Click "Save Config"

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @gwharton. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @orlangur, thank you for the review.
ENGCOM-5450 has been created to process this Pull Request
✳️ @orlangur, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[VladimirZaets]

Hi @gwharton.
The next 2.2 release will be the last of functional releases.
Due to it, we are closing 2.2-develop for contribution.
Thanks for collaboration.

[m2-assistant]

Hi @gwharton, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.