Resolved configurable product image not showing as per selected options #24383

[rani-priya]

Resolved configurable product image not showing as per selected options #24383

Description (*)

Fixed Issues (if relevant)

1. Configurable product image not showing as per selected options #24383: configurable product image not showing as per selected options
2. Product page gallery doesn't update product images #16409: Product page gallery doesn't update product images

Manual testing scenarios (*)

1. Create a configurable product with swatches
2. Set image for each associated products
3. Navigate to product page at frontend
4. Select second or third image of main product
   5 . Then select any option it's not showing the actual image, it's showing previous image.

Questions or comments

[m2-assistant]

Hi @rani-webkul. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[dmytro-ch]

@magento give me test instance

[magento-engcom-team]

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-24384.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[dmytro-ch]

Hi @rani-webkul, unfortunately, the issue is still reproducible in your working branch according to the steps to reproduce mentioned in PR description.

[rani-priya]

@dmytro-ch as I checked, the actual issue is in magento 2.3-develop branch. this commit is working fine on Magento 2.3.2 version and the issue is, in magento 2.3-develop configurable product selected option image is not showing in any condition.

[ihor-sviziev]

Hi @rani-webkul,

Could you configure product on test instance?

I just tried on https://pr-24384.instances.magento-community.engineering/test.html - it doesn't work : (

[ihor-sviziev]

@rani-webkul sorry for confusing. I mist misunderstood your comment at first.

Looks like issue when none of images are selected for configurable products - blocks this PR. Could you report it?
For now I'll put this PR is on hold until original issue will be fixed.

[rani-priya]

Hi @ihor-sviziev,
could you please let me know, where I can report it?

[ihor-sviziev]

Hi @ihor-sviziev,
could you please let me know, where I can report it?

Here: https://github.com/magento/magento2/issues/new/choose :)

[rani-priya]

Hi @ihor-sviziev ,
#24571

[ihor-sviziev]

Thank you for report! We'll keep this Pull Request "on hold" till #24571 will be fixed

[ihor-sviziev]

Hi @rani-webkul,

While investigating #24571 - I found that issue with first image was already fixed in #23033, that I was able to reproduce on test instance in #24571.

Could you confirm that this issue was fixed?

[rani-priya]

@ihor-sviziev
Please look into https://pr-24384.instances.magento-community.engineering/test.html now this commit is working.

Actual issue is #24383

[ihor-sviziev]

@ihor-sviziev
Please look into https://pr-24384.instances.magento-community.engineering/test.html now this commit is working.

Actual issue is #24383

It worked for me even without changes from this PR just because of changes from #23033 (were merged 3 months ago).

I just cheked it on following test instance that was created from 2.3-develop:
https://i-24571-2-3-develop.instances.magento-community.engineering/test-config.html

Here is video: test config - Google Chrome 2019-09-13 09-37-39.zip

[ihor-sviziev]

Hi @rani-webkul,
Thank you for your contribution!

I'm closing this PR as this issue was already fixed in #23033.

Feel free to add any comments if you have any.

[m2-assistant]

Hi @rani-webkul, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.