Skip to content

Add wordwrap to Mail Message body. #24529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

delgor
Copy link

@delgor delgor commented Sep 9, 2019

Description (*)

Add a word wrap to the Mail::Message::setBody() function to ensure the maximum line length of an e-mail as specified in http://www.rfc-editor.org/rfc/rfc5322.txt Section 2.1.1

Fixed Issues (if relevant)

  1. Mail line length too long, breaks DKIM signature #24528: Mail line length too long, breaks DKIM signature

Manual testing scenarios (*)

  1. Let Magento send any e-mail (Newsletter subscription, Customer registration, password recovery).

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@delgor delgor requested a review from melnikovi as a code owner September 9, 2019 15:00
@m2-assistant
Copy link

m2-assistant bot commented Sep 9, 2019

Hi @delgor. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

Copy link
Contributor

@VladimirZaets VladimirZaets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @delgor , please, sign CLA, otherwise, we can't process your pull request

@ghost ghost assigned VladimirZaets Sep 9, 2019
@delgor
Copy link
Author

delgor commented Sep 9, 2019

I signed the CLA.

I see that the Database Compare build is failing - considering that my change is nowhere near the database, could this be an error in the check? What needs to be done here?

@gwharton
Copy link
Contributor

Already fixed in 2.3-develop by changing encoding type to QUOTED PRINTABLE.

@gwharton
Copy link
Contributor

Closing this PR as no longer required. Please reopen and comment if the solution already merged in 2.3-develop does not resolve your issue. #23649

@gwharton gwharton closed this Sep 10, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 10, 2019

Hi @delgor, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants