#25199 Remove quotes when not necessary

[amenk]

see Ticket #25199

[m2-assistant]

Hi @amenk. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[amenk]

Actually the approach to threat all possible integers in all columns might cause problems for varchars.

Because of this behavior in MySQL: http://sqlfiddle.com/#!9/1c01c9/1/0

While my patch is fine for entity_id fields, now if Magento tries to match an SKU like (string) '1', my patch would convert this to a (int) 1 and match also SKUs like '1-2', '1-3' and so on.

[amenk]

Alternative patch:

vendor/magento/module-catalog/Model/Indexer/Category/Product/Action/Full.php:285

    foreach ($batchQueries as $query) {
        $this->connection->delete($this->tableMaintainer->getMainTmpTable((int)$store->getId()));
        $entityIds = $this->connection->fetchCol($query);
        foreach($entityIds as &$val) {  ##patch
            $val = (integer) $val; ## patch
        } ##patch
        $resultSelect = clone $basicSelect;
        $resultSelect->where($whereCondition, $entityIds);
        $this->connect

[mropanen]

Also strings like '23523523e2353253562356' are is_numeric == true ;)
I ended up doing this as a quick fix:
if (is_numeric($val) && $val < INF) {

[amenk]

@mropanen you have to be careful to not threat numeric SKUs as int. This can have the side effects I described.

[robert-scheck]

While the patch indeed solves the issue with "Category Products index", it doesn't address the (same?) issue at "Product Price index". Just ending up here with:

SQLSTATE[HY000]: General error: 1205 Lock wait timeout exceeded; try restarting transaction, query was: DELETE FROM `catalog_product_index_website`

Aside of that, it feels like the patch makes the indexer slower (factor ~ 1.5) in general.

[ihor-sviziev]

Hi @amenk ,
I see that we have two solutions for fixing this issue. Just reviewed both of them and I see that following solution is better https://github.com/magento/magento2/pull/27129/files#diff-ffe9c9bcf0327071a617f8ba7bbfde56R285 as it's fixes root of the issue and not affecting almost all queries in the magento and custom extensions.

As we have better solution - I'm closing this PR.
Thank you so much for contribution!

[m2-assistant]

Hi @amenk, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.