Skip to content

Fix #23031: Check data\schema patch aliases #25265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

korostii
Copy link
Contributor

@korostii korostii commented Oct 24, 2019

Description (*)

If a data or schema patch has an alias that is already present in patch_list, the patch is assumed to be the same patch and should not be applied (again).

Fixed Issues (if relevant)

  1. [Magento 2.3.x] Declarative Schema :: Data/Schema Patches getAliases() not working as expected #23031: [Magento 2.3.x] Declarative Schema :: Data/Schema Patches getAliases() not working as expected

Manual testing scenarios (*)

Please see #23031 for detailed steps.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@korostii korostii requested a review from buskamuza as a code owner October 24, 2019 11:37
@m2-assistant
Copy link

m2-assistant bot commented Oct 24, 2019

Hi @korostii. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@korostii korostii force-pushed the korostii-patch-23031 branch from 05e90d3 to d135cb1 Compare October 24, 2019 12:26
@ghost ghost assigned aleron75 Oct 25, 2019
@aleron75 aleron75 added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix and removed Progress: ready for testing labels Oct 25, 2019
@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-6166 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Oct 25, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:
before

After:
after

@m2-assistant
Copy link

m2-assistant bot commented Oct 26, 2019

Hi @korostii, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants