Fix #25243

[korostii]

Description (*)

JS version of __('Carrier with such method not found: %1, %2', 'one', 'two') should produce the message of 'Carrier with such method not found: one, two'

JS component receives a pre-translated message template yet parameters are sent separately:

And then the messages.js assumes that resulting messageObj property names should match the varNames in the message template string (discounting the first % symbol) which happens to be off by one if the varNames are integers.

Worth mentioning: in most cases they are numbers, however support for string varNames seems to be implied and even relied on, for example there a translated string like the following: You can check the status of your order by <a href=""%account_url"">logging into your account</a>..

Solution: simply decrement varName (as long as it's a number).

Fixed Issues

1. Numerical placeholder count in Phrase starts with %1, however js code assumes 0% #25243: Numerical placeholder count in Phrase starts with %1, however JS code assumes %0

Manual testing scenarios

Please see #25243 for detailed steps.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @korostii. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[engcom-Alfa]

Hi @korostii.
Due to Magento Definition of Done all code must be covered by tests. Please cover your fix by jasmine test.
Thanks!

[korostii]

Hi @engcom-Alfa so we've looked into these jasmine tests as used by Magento with a colleague of mine, as guided by the devdocs article and we can't seem to figure out if it supports frontend theme tests, at all (and this PR deals with JS used on frontend).
So for example grunt spec:backend does run some tests (some of them failing on a clean Magento), whereas grunt spec:frontend doesn't seem to invoke Jasmine, at all:

Any hints/directions?

[krzksz]

@korostii You can try grunt spec:blank and grunt spec:luma.

[engcom-Golf]

HI @krzksz could you please review new changes ?

[krzksz]

Hey, thanks for the update! Unfortunately there is still this thing I mentioned in #25359 (review) which should be taken into account in my opinion.

Pull Request state was updated. Re-review required.

[engcom-Golf]

@krzksz could you please take a look ?

[magento-engcom-team]

Hi @krzksz, thank you for the review.
ENGCOM-6996 has been created to process this Pull Request
✳️ @krzksz, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Alfa]

✔️ QA Passed

Before:

After:

[m2-assistant]

Hi @korostii, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.