fix for Issue #25434 Mail address email constructor argument type inc…

[karyna-t]

Description (*)

fix for Issue #25434 Mail address email constructor argument type incorrect

Fixed Issues (if relevant)

1. Mail address email constructor argument type incorrect #25434: Mail address email constructor argument type incorrect

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @karyna-tsymbal-atwix. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[rogyar]

I would suggest changing the getEmail() method instead of changing the constructor parameters. So we have the constructor untouched but

public function getEmail(): ?string

This solution will be more consistent considering the same approach in getName() method.

Thank you

[rogyar]

Also, after the proposed change, could you cover this case with a unit test, please? The test will instantiate the object with no email and invoke getEmail() method. Then it will assert that no exception is being thrown.

Thank you!

[rogyar]

For QA
We can consider this change as "slightly" backward-incompatible since we are changing the public method signature. However, this change is necessary since it fixes a pretty critical issue

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-6240 has been created to process this Pull Request

[engcom-Bravo]

✔️ QA Passed

[m2-assistant]

Hi @karyna-tsymbal-atwix, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.