Skip to content

Add escaping on meta properties for open graph #25655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2019
Merged

Add escaping on meta properties for open graph #25655

merged 1 commit into from
Dec 9, 2019

Conversation

NathMorgan
Copy link
Member

Description (*)

Added block html attribute escaping on OpenGraph meta description / title due to content bleeding from double quotes

Fixed Issues (if relevant)

  1. Magento OpenGraph meta description / title content bleeding #25654: Magento OpenGraph meta description / title content bleeding

Manual testing scenarios (*)

  1. Create a product in the admin
  2. Within the product description / title create a sample description that contains double quotes "

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@NathMorgan
Add escaping on meta properties for open graph
cb1b774 
Fixes issue where double quotes can bleed though the html attribute
@NathMorgan NathMorgan requested a review from akaplya as a code owner November 19, 2019 15:16
@m2-assistant
Copy link

m2-assistant bot commented Nov 19, 2019

Hi @NathMorgan. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost assigned lbajsarowicz Nov 20, 2019
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6300 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa engcom-Alfa self-assigned this Nov 20, 2019
@engcom-Alfa engcom-Alfa added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Nov 20, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@abrarpathan19
Copy link
Contributor

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @abrarpathan19. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @abrarpathan19, here is your Magento instance.
Admin access: https://i-25655-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@engcom-Foxtrot engcom-Foxtrot self-assigned this Nov 20, 2019
@engcom-Foxtrot engcom-Foxtrot added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Nov 20, 2019
@engcom-Foxtrot
Copy link
Contributor

@NathMorgan please cover changes with functional test.

@NathMorgan
Copy link
Member Author

@engcom-Foxtrot As this is a frontend change by adding escaping what functional test do you wish for me to provide?

rodrigowebjump
rodrigowebjump approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@rodrigowebjump rodrigowebjump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NathMorgan
Thanks for your contribution

@ghost ghost assigned rodrigowebjump Nov 20, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, thank you for the review.
ENGCOM-6300 has been created to process this Pull Request

@NathMorgan
Copy link
Member Author

Any information on what functional test you wish for this change? See #25655 (comment)

@VladimirZaets VladimirZaets added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Dec 3, 2019
VladimirZaets
VladimirZaets approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@VladimirZaets VladimirZaets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NathMorgan. Thanks for collaboration. I don't think that we should cover these changes

@ghost ghost assigned VladimirZaets Dec 3, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-6300 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:12
@VladimirZaets VladimirZaets mentioned this pull request Dec 9, 2019
Closed
magento-engcom-team pushed a commit that referenced this pull request Dec 9, 2019
@VladimirZaets
ENGCOM-6300: Add escaping on meta properties for open graph #25655
3635465
@magento-engcom-team magento-engcom-team merged commit cb1b774 into magento:2.4-develop Dec 9, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 9, 2019

Hi @NathMorgan, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigowebjump rodrigowebjump rodrigowebjump approved these changes

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

@VladimirZaets VladimirZaets VladimirZaets approved these changes

@akaplya akaplya Awaiting requested review from akaplya

Assignees

@rodrigowebjump rodrigowebjump

@lbajsarowicz lbajsarowicz

@VladimirZaets VladimirZaets

@engcom-Alfa engcom-Alfa

@engcom-Foxtrot engcom-Foxtrot

Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: Catalog Partner: Fisheye partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@NathMorgan @magento-engcom-team @engcom-Alfa @abrarpathan19 @engcom-Foxtrot @rodrigowebjump @lbajsarowicz @VladimirZaets @sidolov