fixed issue 25433

[Ashna-Jahan]

Description (*)

I think this is not an issue since there is a trash icon at the end of the line item so, user can click on it to get rid of the validation,
In this fix we have Increased the width of the div so that the trash icon will be visible to user in first glance.

Fixed Issues (if relevant)

1. Close (X) not working when error come for qty #25433: Close (X) not working when error come for qty

Manual testing scenarios (*)

1. Go to advanced pricing area and click on 'Add'.
2. After this fix the trash Icon will be displayed in first glance so that the user can click on it for getting rid of the validation.
3. Please look into the screenshot below.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @Ashna-Jahan. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[kalpmehta]

@magento give me 2.3-develop instance

[magento-engcom-team]

Hi @kalpmehta. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @kalpmehta, here is your Magento instance.
Admin access: https://i-25759-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[kalpmehta]

@magento give me test instance

[magento-engcom-team]

Hi @kalpmehta. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @kalpmehta, here is your new Magento instance.
Admin access: https://pr-25759.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[kalpmehta]

Hi @Ashna-Jahan, thanks for your contribution. I still see this issue occurring when the screen width is less than 768 px. This looks like a half fix. Do you have any idea on how to resolve this for lesser than 768 px devices too?

[kanthy-i95dev]

@Ashna-Jahan please check @kalpmehta comments

[Ashna-Jahan]

Hi @kalpmehta, this is working fine in my devices (android and iPhone) with this fix. Please find the below screenshots. For your reference

Please provide screenshots is you still able to reproduce.

[kalpmehta]

Thank you @Ashna-Jahan for additional information. I agree it's working on desktop and mobile, but if you could resize your browser to mock lesser than 768 px you will notice the original issue.

Attaching the screenshot:

I think I'm good with the half fix for now, however, if you can please remove "!important" from the CSS additions that would be great. Generally it's not a good idea to use !important. Let me know if you need any help!

[kalpmehta]

@magento give me test instance

[magento-engcom-team]

Hi @kalpmehta. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @kalpmehta, here is your new Magento instance.
Admin access: https://pr-25759.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[magento-engcom-team]

Hi @kalpmehta, thank you for the review.
ENGCOM-6375 has been created to process this Pull Request

[magento-engcom-team]

Hi @kalpmehta, thank you for the review.
ENGCOM-6375 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Actual Result:

[m2-assistant]

Hi @Ashna-Jahan, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.