Skip to content

Change tag name #25777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed

Conversation

AndreyChorniy
Copy link
Contributor

Description (*)

This PR fixes the unnecessary issue in exeption.log

Fixed Issues (if relevant)

  1. DOMDocument::loadHTML(): Tag date invalid in Entity #25738: DOMDocument::loadHTML(): Tag date invalid in Entity

Manual testing scenarios (*)

  1. Create a new customer or Login with an existing (user should be logged in)
  2. Place order
  3. Go to Order view page (you can delete exeption.log before)
  4. Check exeption.log (It should not contain DOMDocument::loadHTML(): Tag date invalid in Entity)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 27, 2019

Hi @AndreyChorniy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@rogyar rogyar self-assigned this Nov 27, 2019
@rogyar
Copy link
Contributor

rogyar commented Nov 27, 2019

With the current implementation, DOMDocument will parse a string as HTML4. So yes, the <date> tag is only supported starting from HTML5. I believe this solution makes sense as a hotfix until libxml_use_internal_errors is implemented globally in the escaper class.

@rogyar rogyar added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests bugfix Award: bug fix and removed bugfix labels Nov 27, 2019
@@ -16,7 +16,6 @@
*/
?>
<?php
$start = microtime(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove this change from the current commit. I believe you have already introduced the same change in another PR.

Thank you.

@m2-assistant
Copy link

m2-assistant bot commented Dec 4, 2019

Hi @AndreyChorniy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@AndreyChorniy
Copy link
Contributor Author

Closed because the new one was created here #25895

@AndreyChorniy AndreyChorniy deleted the change-tag-name branch December 4, 2019 08:45
@rogyar rogyar mentioned this pull request Dec 4, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: Catalog Component: Sales Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: needs update Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants