Skip to content

[Ui] Adding admin class for password input type. #25918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

eduard13
Copy link
Contributor

@eduard13 eduard13 commented Dec 5, 2019

Description (*)

This PR fixes the password type input, by applying the proper class name. It also removes the classes for existing inputs, to avoid duplicated class names.

Fixed Issues (if relevant)

  1. Admin confirm password input doesn't inherit needed styles #25917: Admin confirm password input doesn't inherit needed styles

Manual testing scenarios (*)

  1. Navigate to System / Integrations
  2. Click on Add New Integration button
  3. Scroll down to Current User Identity Verification fieldset

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 5, 2019

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@dmytro-ch dmytro-ch added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix labels Dec 7, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6414 has been created to process this Pull Request

@ghost
Copy link

ghost commented Dec 9, 2019

@Nazar65 unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@engcom-Golf engcom-Golf self-assigned this Dec 9, 2019
@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

@engcom-Golf engcom-Golf added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Dec 9, 2019
@engcom-Golf engcom-Golf added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Dec 9, 2019
@magento-engcom-team magento-engcom-team merged commit 3e65b37 into magento:2.4-develop Dec 10, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 10, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: Backend Component: Data Component: Integration Component: User Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants