Skip to content

Resolve Refresh Statistics: Updated At = Null should be display as "Never" instead of "undefined". issue25931 #25932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 10, 2019
Merged

Resolve Refresh Statistics: Updated At = Null should be display as "Never" instead of "undefined". issue25931 #25932

merged 4 commits into from
Dec 10, 2019

Conversation

edenduong
Copy link
Contributor

Description (*)

  1. Resolve Refresh Statistics: Updated At = Null should be display as "Never" instead of "undefined". #25931: Refresh Statistics: Updated At = Null should be display as "Never" instead of "undefined".

Fixed Issues (if relevant)

  1. Refresh Statistics: Updated At = Null should be display as "Never" instead of "undefined". #25931: Refresh Statistics: Updated At = Null should be display as "Never" instead of "undefined".

Manual testing scenarios (*)

  1. Go to backend
  2. Reports-> Refresh Statistics

Expected result

image

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 6, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@m2-assistant
Copy link

m2-assistant bot commented Dec 6, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@edenduong edenduong reopened this Dec 6, 2019
@magento magento deleted a comment from magento-engcom-team Dec 6, 2019
@ghost ghost assigned krzksz Dec 7, 2019
@krzksz krzksz added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Dec 7, 2019
@magento-engcom-team
Copy link
Contributor

Hi @krzksz, thank you for the review.
ENGCOM-6427 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Dec 8, 2019
@engcom-Alfa
Copy link
Contributor

Hi @edenduong .
Due to Magento Definition of Done all code must be covered by tests. Please cover your fix by automated tests.
Thanks!

@edenduong
Copy link
Contributor Author

@krzksz @engcom-Alfa : I have just covered it with Integration Test. Please check it.
Thank you very much!

@engcom-Alfa engcom-Alfa requested a review from krzksz December 9, 2019 09:54
@krzksz krzksz added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Dec 9, 2019
@magento-engcom-team
Copy link
Contributor

Hi @krzksz, thank you for the review.
ENGCOM-6427 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:
before

After:
after

@engcom-Golf engcom-Golf self-assigned this Dec 9, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Dec 10, 2019
Closed
magento-engcom-team pushed a commit that referenced this pull request Dec 10, 2019
@VladimirZaets
ENGCOM-6427: Resolve Refresh Statistics: Updated At = Null should be …
7965b96 
…display as "Never" instead of "undefined". issue25931 #25932
@magento-engcom-team magento-engcom-team merged commit a0b7436 into magento:2.4-develop Dec 10, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 10, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzksz krzksz krzksz approved these changes

@buskamuza buskamuza Awaiting requested review from buskamuza

@tariqjawed83 tariqjawed83 Awaiting requested review from tariqjawed83

Assignees

@krzksz krzksz

@engcom-Alfa engcom-Alfa

@engcom-Golf engcom-Golf

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Reports Progress: accept Release Line: 2.4 tech-partners-contribution Technology Partner: Magestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refresh Statistics: Updated At = Null should be display as "Never" instead of "undefined".
5 participants
@edenduong @magento-engcom-team @engcom-Alfa @krzksz @engcom-Golf