Skip to content

#25591 & character in SKUs is shown as & in current variations li… #26007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 9, 2020
Merged

#25591 & character in SKUs is shown as & in current variations li… #26007

merged 7 commits into from
Feb 9, 2020

Conversation

KaushikChavda
Copy link
Contributor

@KaushikChavda KaushikChavda commented Dec 12, 2019 •
edited
Loading

…st on configurable products

  • Fixed the issue SKU special character which change to encoded version.

Description (*)

Fixed Issues (if relevant)

  1. & character in SKUs is shown as & in current variations list on configurable products  #25591: & character in SKUs is shown as & in current variations list on configurable products

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

magento#25591 & character in SKUs is shown as & in current variat…
b3e6049 
…ions list on configurable products

 - Fixed the issue SKU special character which change to encoded version.
@m2-assistant
Copy link

m2-assistant bot commented Dec 12, 2019

Hi @KaushikChavda. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

swnsma
swnsma requested changes Dec 14, 2019
View reviewed changes
Copy link
Contributor

@swnsma swnsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @KaushikChavda!
Thank you for your contribution!

May we keep '' as it was before?
Please see my suggestions.

@ghost ghost assigned swnsma Dec 14, 2019
@swnsma swnsma self-requested a review December 16, 2019 10:40
swnsma
swnsma approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@swnsma swnsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA could you please also verify that MAGETWO-88649: Wrong swatches behavior is not being reproduced with codebase of this PR?

@magento-engcom-team
Copy link
Contributor

Hi @swnsma, thank you for the review.
ENGCOM-6483 has been created to process this Pull Request
✳️ @swnsma, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Charlie engcom-Charlie self-assigned this Dec 16, 2019
@engcom-Charlie
Copy link
Contributor

Hi @KaushikChavda

Due to Magento Definition of Done all code must be covered by tests. Please cover your fix by automated tests.

Thanks!

@swnsma
Copy link
Contributor

swnsma commented Jan 10, 2020

Hi @KaushikChavda!
Will you proceed with tests coverage?

@engcom-Golf engcom-Golf self-assigned this Feb 5, 2020
@engcom-Golf engcom-Golf added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Feb 5, 2020
@swnsma swnsma self-requested a review February 5, 2020 16:08
@magento-engcom-team
Copy link
Contributor

Hi @swnsma, thank you for the review.
ENGCOM-6483 has been created to process this Pull Request

@swnsma swnsma self-requested a review February 5, 2020 16:10
@swnsma
Copy link
Contributor

swnsma commented Feb 5, 2020

@magento run all tests

@engcom-Bravo engcom-Bravo self-assigned this Feb 6, 2020
@engcom-Golf
Copy link
Contributor

Failed functional test not related to the changes in this PR, test fails on 2.4-develop branch.

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

The amp text is not added to the sku
configurable_sku

@slavvka slavvka mentioned this pull request Feb 9, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Feb 9, 2020
@slavvka
ENGCOM-6483: #25591 & character in SKUs is shown as & in current …
a1d3605 
…variations li… #26007
@magento-engcom-team magento-engcom-team merged commit 861f492 into magento:2.4-develop Feb 9, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2020

Hi @KaushikChavda, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@KaushikChavda KaushikChavda deleted the issue/2.4/25591 branch September 10, 2020 11:21
@SilinMykola SilinMykola mentioned this pull request May 6, 2021
Merged
6 tasks
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrewML DrewML Awaiting requested review from DrewML

@swnsma swnsma Awaiting requested review from swnsma

Assignees

@swnsma swnsma

@engcom-Bravo engcom-Bravo

@engcom-Charlie engcom-Charlie

@engcom-Golf engcom-Golf

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage Component: ConfigurableProduct Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@KaushikChavda @magento-engcom-team @engcom-Charlie @swnsma @engcom-Golf @engcom-Bravo @Nazar65