Skip to content

Added Fix for issue 26168 #26169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2020
Merged

Added Fix for issue 26168 #26169

merged 1 commit into from
Jan 8, 2020

Conversation

divyajyothi5321
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Input Checkbox Alignment Issue at checkout page in Safari Browser #26168: Input Checkbox Alignment Issue at checkout page in Safari Browser

Manual testing scenarios (*)

  1. Go to Front end, add any product to Cart.
  2. Go to Checkout Page.
  3. Fill all the shipping details
  4. Then go to Review and payments
  5. With this fix the checkbox is aligned properly as shown below
    checkbox-expected

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 24, 2019

Hi @divyajyothi5321. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: i95Dev partners-contribution Pull Request is created by Magento Partner labels Dec 24, 2019
@rogyar rogyar self-assigned this Dec 24, 2019
@rogyar
Copy link
Contributor

rogyar commented Dec 24, 2019

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your Magento instance.
Admin access: https://i-26169-2-4-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@rogyar
Copy link
Contributor

rogyar commented Dec 24, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-26169.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@rogyar rogyar added Component: Checkout Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Dec 24, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-6521 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Dec 24, 2019
@engcom-Alfa
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Alfa. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Alfa, here is your Magento instance.
Admin access: https://i-26169-2-4-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@engcom-Alfa
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Alfa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Alfa, here is your new Magento instance.
Admin access: https://pr-26169.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@engcom-Alfa
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Alfa. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Alfa, here is your Magento instance.
Admin access: https://i-26169-2-4-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@engcom-Alfa
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Alfa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Alfa, here is your new Magento instance.
Admin access: https://pr-26169.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Golf engcom-Golf self-assigned this Jan 3, 2020
@VladimirZaets VladimirZaets mentioned this pull request Jan 8, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Jan 8, 2020
@VladimirZaets
ENGCOM-6521: Added Fix for issue 26168 #26169
f3fdbb6
@magento-engcom-team magento-engcom-team merged commit 9882e96 into magento:2.4-develop Jan 8, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 8, 2020

Hi @divyajyothi5321, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

@kanthy-i95dev kanthy-i95dev kanthy-i95dev approved these changes

Assignees

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Golf engcom-Golf

Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Partner: i95Dev partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@divyajyothi5321 @rogyar @magento-engcom-team @engcom-Alfa @kanthy-i95dev @dmytro-ch @engcom-Golf