Skip to content

#26206 Add information about currently reindexed index. #26207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented Dec 30, 2019

Description (*)

Answers the need for more information about failed reindex.

ezgif-7-84cd063d47d7

Change additionally improves performance by replacing foreach() { array_merge() } with array_merge(...$args). Additionally with -v debug information included about exception trace.

Fixed Issues (if relevant)

  1. Missing information about currently reindexed index on failure #26206 Missing information about the currently reindexed index on failure

Manual testing scenarios (*)

  1. Run desired reindex. Expect the reindex name to be immediately visible

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 30, 2019

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Strix partners-contribution Pull Request is created by Magento Partner labels Dec 30, 2019
@lbajsarowicz lbajsarowicz force-pushed the feature/26206-reindex-info branch from b89d577 to 79fe786 Compare December 31, 2019 00:11
@pmclain pmclain self-requested a review December 31, 2019 12:04
@pmclain pmclain self-assigned this Dec 31, 2019
@lbajsarowicz
Copy link
Contributor Author

Clean 2.4-develop also fails the same test for me. Rolling back my changes to see if it's issue related with 2.4-develop itself, or can I fix that.

The integration test is - in general - useless, written wrong way, so I'm not sure about it's corectness.

@lbajsarowicz lbajsarowicz force-pushed the feature/26206-reindex-info branch from 42c65e5 to f67a576 Compare January 1, 2020 13:40
@lbajsarowicz lbajsarowicz force-pushed the feature/26206-reindex-info branch from 88455bd to 5bdadc0 Compare January 2, 2020 01:11
@lbajsarowicz
Copy link
Contributor Author

#26225 Has to be merged first (!).
↑ is already merged to this feature branch, to pass the Integration and Functional Tests.

@magento-engcom-team
Copy link
Contributor

Hi @pmclain, thank you for the review.
ENGCOM-6533 has been created to process this Pull Request
✳️ @pmclain, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Jan 8, 2020

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants