Skip to content

FIX issue#26217 - Wrong fields selection while using fragments on GraphQL #26218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

phoenix128
Copy link
Contributor

Wrong fields selection while using fragments on GraphQL products query

Description (*)

The proposed solution is to use \GraphQL\Type\Definition\ResolveInfo::getFieldSelection to retrieve the fields list instead of the previsous implementation.

Fixed Issues (if relevant)

  1. Wrong fields selection while using fragments on GraphQL products query #26217: Wrong fields selection while using fragments on GraphQL

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 31, 2019

Hi @phoenix128. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: MageSpecialist partners-contribution Pull Request is created by Magento Partner labels Dec 31, 2019
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-6535 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@lenaorobei
Copy link
Contributor

@magento run Integration Tests

@engcom-Bravo engcom-Bravo self-requested a review January 6, 2020 13:05
@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

@lenaorobei
Copy link
Contributor

@phoenix128, could you please add api-functional test to this PR with the query provided in the issue?

@phoenix128 phoenix128 requested a review from paliarush as a code owner January 8, 2020 22:02
@lenaorobei lenaorobei added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Progress: needs update labels Jan 8, 2020
@ghost ghost added the Progress: accept label Jan 8, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 9, 2020

Hi @phoenix128, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: CatalogGraphQl Partner: MageSpecialist partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants