Skip to content

#26240: Fixed logic for getting option price index for selected swatch option #26241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 8, 2020
Merged

#26240: Fixed logic for getting option price index for selected swatch option #26241

merged 6 commits into from
Feb 8, 2020

Conversation

sergiy-v
Copy link
Contributor

@sergiy-v sergiy-v commented Jan 2, 2020 •
edited
Loading

Description (*)

Fixed logic for getting option price index for selected swatch option.

Fixed Issues (if relevant)

  1. Minimum Advertised Price doesn't change for selected swatch option for configurable product #26240

Manual testing scenarios (*)

  1. Enable MAP (Store -> Configuration -> Sales -> Sales -> Minimum Advertised Price -> Enable MAP).

  2. Create configurable product for attribute with 'swatch' (Visual Swatch, Text Swatch) type with assoshiated products:

  • simple A: price 1, MAP 11. (ex: 'black' color)
  • simple B: price 1, MAP 12. (ex: 'white' color)

Expected result

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@sergiy-v sergiy-v requested a review from DrewML as a code owner January 2, 2020 15:35
@m2-assistant
Copy link

m2-assistant bot commented Jan 2, 2020

Hi @sergiy-v. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 2, 2020
lbajsarowicz
lbajsarowicz suggested changes Jan 2, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge latest 2.4-develop and fix static tests.

@ghost ghost assigned lbajsarowicz Jan 2, 2020
@sergiy-v
Copy link
Contributor Author

sergiy-v commented Jan 3, 2020 •
edited
Loading

Merge latest 2.4-develop and fix static tests.

Merged 2.4-develop and fixed static tests, thanks.

@sergiy-v sergiy-v requested a review from lbajsarowicz January 3, 2020 08:14
@sergiy-v sergiy-v mentioned this pull request Jan 27, 2020
Merged
4 tasks
@dmytro-ch dmytro-ch added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix labels Jan 29, 2020
@ghost ghost assigned dmytro-ch Jan 29, 2020
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6750 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Jan 29, 2020
@engcom-Golf engcom-Golf self-assigned this Jan 29, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Golf
Copy link
Contributor

Failed Functional tests not related to changes in this PR, tests fail on 2.4-develop branch

@lbajsarowicz
Copy link
Contributor

Already #26608 to be addressed.

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6750 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@slavvka slavvka mentioned this pull request Feb 8, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Feb 8, 2020
@slavvka
ENGCOM-6750: #26240: Fixed logic for getting option price index for s…
11a67d0 
…elected swatch option #26241
@magento-engcom-team magento-engcom-team merged commit 4ace1e6 into magento:2.4-develop Feb 8, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 8, 2020

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch approved these changes

@DrewML DrewML Awaiting requested review from DrewML

@lbajsarowicz lbajsarowicz Awaiting requested review from lbajsarowicz

Assignees

@lbajsarowicz lbajsarowicz

@dmytro-ch dmytro-ch

@engcom-Alfa engcom-Alfa

@engcom-Golf engcom-Golf

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage Component: Swatches Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sergiy-v @magento-engcom-team @engcom-Alfa @engcom-Golf @lbajsarowicz @dmytro-ch @Nazar65