Skip to content

Add missing annotations to MFTF tests #26615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sta1r
Copy link
Contributor

@sta1r sta1r commented Jan 31, 2020

Description (*)

This PR addresses a number of DEPRECATION: notices raised when running MFTF tests.

The notices related to missing stories and severity annotations. I've tried wherever possible to follow the lead of sibling tests e.g. if a test has no severity annotation and all the other tests in its folder say <severity>CRITICAL</critical>, also mark as critical.

Questions or comments

It's worth noting that the devdocs:

  • don't advise on differences in severity grade
  • don't really clarify the distinction between (or hierarchy of) stories and features

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 31, 2020

Hi @sta1r. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@lbajsarowicz
Copy link
Contributor

Covered already in https://github.com/magento/magento2/pull/26391/files - I'd like to keep your PR to cover elements that are not covered by above mentioned PR.

Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for https://github.com/magento/magento2/pull/26391/files to be merged, then resolve conficts.

@ghost ghost assigned lbajsarowicz Feb 1, 2020
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sta1r,
Could you please resolve conflicts?

@ghost ghost assigned ihor-sviziev Feb 17, 2020
@sta1r
Copy link
Contributor Author

sta1r commented Feb 24, 2020

@ihor-sviziev conflicts resolved!

@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Feb 25, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6975 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

QA not applicable

@m2-assistant
Copy link

m2-assistant bot commented Feb 28, 2020

Hi @sta1r, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants