-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Add missing annotations to MFTF tests #26615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing annotations to MFTF tests #26615
Conversation
Hi @sta1r. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Covered already in https://github.com/magento/magento2/pull/26391/files - I'd like to keep your PR to cover elements that are not covered by above mentioned PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for https://github.com/magento/magento2/pull/26391/files to be merged, then resolve conficts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sta1r,
Could you please resolve conflicts?
@ihor-sviziev conflicts resolved! |
Hi @ihor-sviziev, thank you for the review. |
QA not applicable |
Hi @sta1r, thank you for your contribution! |
Description (*)
This PR addresses a number of
DEPRECATION:
notices raised when running MFTF tests.The notices related to missing
stories
andseverity
annotations. I've tried wherever possible to follow the lead of sibling tests e.g. if a test has noseverity
annotation and all the other tests in its folder say<severity>CRITICAL</critical>
, also mark as critical.Questions or comments
It's worth noting that the devdocs:
Contribution checklist (*)