Skip to content

Xml fixes for Magento_AdvancedPricingImportExport module #26634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 8, 2020
Merged

Xml fixes for Magento_AdvancedPricingImportExport module #26634

merged 2 commits into from
Feb 8, 2020

Conversation

sanganinamrata
Copy link
Member

Description (*)

Finetuned module.xml

Related Pull Requests

N/A

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

@m2-assistant
Copy link

m2-assistant bot commented Feb 2, 2020

Hi @sanganinamrata. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost assigned ihor-sviziev Feb 2, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup labels Feb 2, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6784 has been created to process this Pull Request

lbajsarowicz
lbajsarowicz suggested changes Feb 2, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint your code.

@ghost ghost assigned lbajsarowicz Feb 2, 2020
@engcom-Alfa engcom-Alfa self-assigned this Feb 4, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6784 has been created to process this Pull Request

lbajsarowicz
lbajsarowicz approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6784 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Charlie engcom-Charlie self-assigned this Feb 4, 2020
@engcom-Charlie
Copy link
Contributor

Failure of functional test, not related to the changes in this PR , test failing on 2.4-develop branch
73529028-a23f8180-441e-11ea-8642-6d0f12b8b6de

magento-engcom-team pushed a commit that referenced this pull request Feb 8, 2020
@slavvka
ENGCOM-6784: Xml fixes for Magento_AdvancedPricingImportExport module #…
1ce92f7 
…26634
@magento-engcom-team magento-engcom-team merged commit 4efe5a0 into magento:2.4-develop Feb 8, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 8, 2020

Hi @sanganinamrata, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@ihor-sviziev ihor-sviziev

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: AdvancedPricingImportExport Event: mm20in Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sanganinamrata @magento-engcom-team @engcom-Alfa @engcom-Charlie @lbajsarowicz @ihor-sviziev @sivaschenko @pratiksangani