Skip to content

[26054-Do not duplicate SEO meta data when duplicating a product] #26659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 20, 2020
Merged

[26054-Do not duplicate SEO meta data when duplicating a product] #26659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1f96b87
[26054-Do not duplicate SEO meta data when duplicating a product]
dasharath-wagento Feb 2, 2020
89b0a9d
refactoring, fix unit test
Nazar65 Feb 6, 2020
99383fc
Merge branch '2.4-develop' into feature-seo-meta-data-duplicating
engcom-Charlie Feb 11, 2020
2d19477
fix static, fix conflict merge
engcom-Charlie Feb 11, 2020
5aea4ac
Merge branch '2.4-develop' into feature-seo-meta-data-duplicating
slavvka Feb 14, 2020
dbf3924
Merge branch '2.4-develop' into feature-seo-meta-data-duplicating
dasharath-wagento Feb 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 16 additions & 17 deletions app/code/Magento/Catalog/Model/Product/Copier.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,12 @@
use Magento\Catalog\Api\Data\ProductInterface;
use Magento\Catalog\Model\Attribute\ScopeOverriddenValue;
use Magento\Catalog\Model\Product;
use Magento\Catalog\Model\Product\Attribute\Source\Status;
use Magento\Catalog\Model\Product\Option\Repository as OptionRepository;
use Magento\Catalog\Model\ProductFactory;
use Magento\Framework\App\ObjectManager;
use Magento\Framework\EntityManager\MetadataPool;
use Magento\Store\Model\Store;
use Magento\UrlRewrite\Model\Exception\UrlAlreadyExistsException;

/**
Expand Down Expand Up @@ -72,40 +74,37 @@ public function __construct(
/**
* Create product duplicate
*
* @param \Magento\Catalog\Model\Product $product
*
* @return \Magento\Catalog\Model\Product
*
* @throws \Exception
* @param Product $product
* @return Product
*/
public function copy(Product $product)
public function copy(Product $product): Product
{
$product->getWebsiteIds();
$product->getCategoryIds();

$metadata = $this->metadataPool->getMetadata(ProductInterface::class);

/** @var \Magento\Catalog\Model\Product $duplicate */
/** @var Product $duplicate */
$duplicate = $this->productFactory->create();
$productData = $product->getData();
$productData = $this->removeStockItem($productData);
$duplicate->setData($productData);
$duplicate->setOptions([]);
$duplicate->setMetaTitle(null);
$duplicate->setMetaKeyword(null);
$duplicate->setMetaDescription(null);
$duplicate->setIsDuplicate(true);
$duplicate->setOriginalLinkId($product->getData($metadata->getLinkField()));
$duplicate->setStatus(\Magento\Catalog\Model\Product\Attribute\Source\Status::STATUS_DISABLED);
$duplicate->setStatus(Status::STATUS_DISABLED);
$duplicate->setCreatedAt(null);
$duplicate->setUpdatedAt(null);
$duplicate->setId(null);
$duplicate->setStoreId(\Magento\Store\Model\Store::DEFAULT_STORE_ID);
$duplicate->setStoreId(Store::DEFAULT_STORE_ID);
$this->copyConstructor->build($product, $duplicate);
$this->setDefaultUrl($product, $duplicate);
$this->setStoresUrl($product, $duplicate);
$this->optionRepository->duplicate($product, $duplicate);
$product->getResource()->duplicate(
$product->getData($metadata->getLinkField()),
$duplicate->getData($metadata->getLinkField())
);

return $duplicate;
}

Expand All @@ -118,11 +117,11 @@ public function copy(Product $product)
*/
private function setDefaultUrl(Product $product, Product $duplicate) : void
{
$duplicate->setStoreId(\Magento\Store\Model\Store::DEFAULT_STORE_ID);
$duplicate->setStoreId(Store::DEFAULT_STORE_ID);
$resource = $product->getResource();
$attribute = $resource->getAttribute('url_key');
$productId = $product->getId();
$urlKey = $resource->getAttributeRawValue($productId, 'url_key', \Magento\Store\Model\Store::DEFAULT_STORE_ID);
$urlKey = $resource->getAttributeRawValue($productId, 'url_key', Store::DEFAULT_STORE_ID);
do {
$urlKey = $this->modifyUrl($urlKey);
$duplicate->setUrlKey($urlKey);
Expand Down Expand Up @@ -175,7 +174,7 @@ private function setStoresUrl(Product $product, Product $duplicate) : void
$productResource->saveAttribute($duplicate, 'url_path');
$productResource->saveAttribute($duplicate, 'url_key');
}
$duplicate->setStoreId(\Magento\Store\Model\Store::DEFAULT_STORE_ID);
$duplicate->setStoreId(Store::DEFAULT_STORE_ID);
}

/**
Expand All @@ -197,7 +196,7 @@ private function modifyUrl(string $urlKey) : string
* @param array $productData
* @return array
*/
private function removeStockItem(array $productData)
private function removeStockItem(array $productData): array
{
if (isset($productData[ProductInterface::EXTENSION_ATTRIBUTES_KEY])) {
$extensionAttributes = $productData[ProductInterface::EXTENSION_ATTRIBUTES_KEY];
Expand Down
Loading