Added The return of Post Value when an Integration Exception is thrown while Save Action #26660

realadityayadav · 2020-02-02T10:02:52Z

This keeps the form data persistent when the an Integration Exception is throw as a case when name of Integration being added is same.

Description (*)

Magento 2.x - This issue reproduce in all version.

Go to System-> Integrations
Add a new Integration , Choose a name that already exist and fill all the form and then hit Save.

Expected - The Save Actions Fails with a message The integration with name "%1" exists. but the form entries are intact.
Actual - The Save Actions Fails with a message The integration with name "%1" exists. but the form entries are reset.

Related Pull Requests

Fixed Issues (if relevant)

magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

[*] Pull request has a meaningful description of its purpose
[*] All commits are accompanied by meaningful commit messages
[*] All new or changed code is covered with unit/integration tests (if applicable)
[*] All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Added The return of Post Value when an Integration Exception is thrown while Save Action #28143: Added The return of Post Value when an Integration Exception is thrown while Save Action

This keeps the form data persistent when the an Integration Exception is throw as a case when name of Integration being added is same.

m2-assistant · 2020-02-02T10:02:55Z

Hi @realadityayadav. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

ghost · 2020-02-02T10:02:55Z

@realadityayadav unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

realadityayadav · 2020-02-02T10:07:55Z

@magento give me test instance

magento-engcom-team · 2020-02-02T10:07:57Z

Hi @realadityayadav. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2020-02-02T10:08:37Z

Hi @realadityayadav, here is your new Magento instance.
Admin access: https://pr-26660.instances.magento-community.engineering/admin_60db
Login: bd4fb776 Password: 7d8c102c5bff
Instance will be terminated in up to 3 hours.

rogyar · 2020-02-02T16:24:27Z

Hi @realadityayadav. Thank you for your collaboration.
According to the new Definition of Done all changes should be covered by automated tests. Could I kindly ask you to cover your changes with an MFTF test which will attempt to create another integration with the same name and assert that the form data persists?

Thank you!

realadityayadav · 2020-02-02T16:33:59Z

Ya why not. Could you guide me to a reference of adding an MFTF please?

sivaschenko · 2020-02-24T15:12:04Z

Probably the last step verifying the form fields should be added to this test: https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Integration/Test/Mftf/Test/AdminCreateIntegrationEntityWithDuplicatedNameTest.xml

realadityayadav · 2020-03-14T10:34:54Z

@rogyar The Test are failing for a different module in the EE & B2B files which are not yet available in this release?
Can you take a look once?

rogyar · 2020-03-16T09:13:10Z

...de/Magento/Integration/Test/Mftf/Test/AdminCreateIntegrationEntityWithDuplicatedNameTest.xml

@@ -46,5 +46,6 @@
            <argument name="message" value="The integration with name &quot;Integration1&quot; exists."/>
            <argument value="error" name="messageType"/>
        </actionGroup>
+        <seeInField stepKey="checkEnteredValueIsPreserved" selector="{{AdminNewIntegrationSection.name}}" userInput="Integration1"/>


Hi @realadityayadav. According to the best practices it's highly recommended to build a test using action groups without direct operations in the test body. As you can see from the test you have edited, it consists of the action groups.

Please, move this check into a new action group and name the action group as AssertAdminIntegrationNameInFormActionGroup. Then you can use the action group in your test.

Thank you!

https://github.com/magento/magento2/pull/26660/files

Please see the recent change now @rogyar

rogyar · 2020-03-18T09:18:26Z

Hi @realadityayadav. Looks like you forgot to create the mentioned action group. According to my previous comment you need to perform the following steps.

Create a new action group (AssertAdminIntegrationNameInFormActionGroup)
Move seeInField check into the newly created action group
Use the newly created action group in the test body.

As far as I see, steps 1-2 are missing so far.

realadityayadav · 2020-03-26T12:13:09Z

I think it is already there. Please check the latest version.

rogyar · 2020-03-28T09:40:53Z

Hi @realadityayadav. You have 2 files modified in your PR: the actual fix and the test. No action group so far.

engcom-Alfa · 2020-05-07T06:50:00Z

✔️ QA Passed

Manual testing scenario:

Go to Admin->System->Integrations;
Add a new Integration;
Choose a name that already exists and fill all the form ;
Save;

Before: ✖️ The form entries are reset.

After: ✔️ The form entries are intact.

slavvka · 2020-05-07T18:16:48Z

@magento create issue

slavvka · 2020-07-07T17:34:52Z

@magento run WebAPI tests

slavvka · 2020-07-07T17:35:36Z

@magento run WebAPI Tests

slavvka · 2020-07-13T05:54:45Z

@magento run Integration Tests

…tion is thrown while Save Action #26660

m2-assistant · 2020-07-16T00:54:12Z

Hi @realadityayadav, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Update Save.php

4459cb0

This keeps the form data persistent when the an Integration Exception is throw as a case when name of Integration being added is same.

realadityayadav added the Event: mm20in label Feb 2, 2020

realadityayadav self-assigned this Feb 2, 2020

ghost unassigned realadityayadav Feb 2, 2020

magento-engcom-team added Community Insider: Cedcommerce community-insider-contribution labels Feb 2, 2020

realadityayadav changed the title ~~Update Save.php~~ Added The return of Post Value when an Integration Exception is thrown while Save Action Feb 2, 2020

rogyar self-assigned this Feb 2, 2020

rogyar added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Feb 2, 2020

rogyar mentioned this pull request Feb 2, 2020

Visa expiration date fix functional test dataset #26665

Closed

Add supporting change for same name integration test

bad241b

rogyar requested changes Mar 16, 2020

View reviewed changes

ghost added the Progress: needs update label Mar 16, 2020

Update AdminCreateIntegrationEntityWithDuplicatedNameTest.xml

aa59c0b

engcom-Charlie self-assigned this May 4, 2020

engcom-Charlie added 2 commits May 4, 2020 10:46

Merge branch '2.4-develop' into realadityayadav-2.4

38bf16e

create new action group

04146b6

engcom-Charlie requested a review from rogyar May 4, 2020 10:45

ghost added Progress: testing in progress and removed Progress: ready for testing labels May 6, 2020

ghost added Progress: extended testing Progress: accept and removed Progress: testing in progress Progress: extended testing labels May 7, 2020

ghost mentioned this pull request May 7, 2020

[Issue] Added The return of Post Value when an Integration Exception is thrown while Save Action #28143

Closed

slavvka added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels May 7, 2020

slavvka added this to the 2.4.1 milestone May 7, 2020

Merge branch '2.4-develop' into 2.4-develop

59f031a

VladimirZaets added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label May 19, 2020

ghost added Progress: extended testing and removed Progress: accept labels May 19, 2020

engcom-Delta added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jun 30, 2020

ghost added Progress: accept and removed Progress: extended testing labels Jun 30, 2020

magento-engcom-team added Partner: Cedcommerce partners-contribution Pull Request is created by Magento Partner labels Jun 30, 2020

Merge branch '2.4-develop' into 2.4-develop

29c7c90

Merge branch '2.4-develop' into 2.4-develop

f172e3c

magento-engcom-team pushed a commit that referenced this pull request Jul 16, 2020

ENGCOM-7523: Added The return of Post Value when an Integration Excep…

5065063

…tion is thrown while Save Action #26660

magento-engcom-team merged commit 7cabedf into magento:2.4-develop Jul 16, 2020

Added The return of Post Value when an Integration Exception is thrown while Save Action #26660

Added The return of Post Value when an Integration Exception is thrown while Save Action #26660

Uh oh!

Conversation

realadityayadav commented Feb 2, 2020 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Feb 2, 2020

Uh oh!

ghost commented Feb 2, 2020

Uh oh!

realadityayadav commented Feb 2, 2020

Uh oh!

magento-engcom-team commented Feb 2, 2020

Uh oh!

magento-engcom-team commented Feb 2, 2020

Uh oh!

rogyar commented Feb 2, 2020

Uh oh!

realadityayadav commented Feb 2, 2020

Uh oh!

sivaschenko commented Feb 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

realadityayadav commented Mar 14, 2020

Uh oh!

rogyar Mar 16, 2020

Choose a reason for hiding this comment

Uh oh!

realadityayadav Mar 18, 2020

Choose a reason for hiding this comment

Uh oh!

rogyar commented Mar 18, 2020

Uh oh!

realadityayadav commented Mar 26, 2020

Uh oh!

rogyar commented Mar 28, 2020

Uh oh!

engcom-Alfa commented May 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

slavvka commented May 7, 2020

Uh oh!

slavvka commented Jul 7, 2020

Uh oh!

slavvka commented Jul 7, 2020

Uh oh!

slavvka commented Jul 13, 2020

Uh oh!

m2-assistant bot commented Jul 16, 2020

Uh oh!

Uh oh!

realadityayadav commented Feb 2, 2020 •

edited by ghost

Loading

sivaschenko commented Feb 24, 2020 •

edited

Loading

engcom-Alfa commented May 7, 2020 •

edited

Loading