[Ui] Don't trigger grid reload at first page load #26984

Den4ik · 2020-02-23T10:40:01Z

This PR contain @api class changes and require architect approval

Related Pull Requests

Description (*)

Each page with ui grid contain not filtered grid collection items from load.
After page load called reload event that load filtered collection via ajax.
Main idea don't load collection via ajax and apply filters from bookmark on page load.

Fixed Issues (if relevant)

Don't trigger reload of ui listing at page load community-features#238: Don't trigger reload of ui listing at page load

Manual testing scenarios (*)

Open sales orders page
Look at page source
Page already contain items and totalRecords at ui config js

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2020-02-23T10:40:04Z

Hi @Den4ik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

Den4ik · 2020-02-23T10:42:51Z

@magento give me 2.4-develop instance

magento-engcom-team · 2020-02-23T10:43:03Z

Hi @Den4ik. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team · 2020-02-23T10:43:36Z

Hi @Den4ik, here is your Magento instance.
Admin access: https://i-26984-2-4-develop.instances.magento-community.engineering/admin_2304
Login: aa93c751 Password: cfaf1f3a9f43
Instance will be terminated in up to 3 hours.

Den4ik · 2020-02-23T10:45:33Z

@magento give me test instance

magento-engcom-team · 2020-02-23T10:45:39Z

Hi @Den4ik. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2020-02-23T10:46:16Z

Hi @Den4ik, here is your new Magento instance.
Admin access: https://pr-26984.instances.magento-community.engineering/admin_6de5
Login: 85ca1fc3 Password: 54dffbc12d9f
Instance will be terminated in up to 3 hours.

ghost · 2020-02-23T10:50:39Z

@Den4ik unfortunately, only members of the maintainers team are allowed to add progress related labels to the pull request

Den4ik · 2020-03-27T15:16:13Z

@magento give me test instance

magento-engcom-team · 2020-03-27T15:16:18Z

Hi @Den4ik. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2020-03-27T15:17:03Z

Hi @Den4ik, here is your new Magento instance.
Admin access: https://pr-26984.instances.magento-community.engineering/admin_0457
Login: c3d7e228 Password: 77b4969eac65
Instance will be terminated in up to 3 hours.

Den4ik · 2020-05-28T11:22:44Z

@magento give me 2.4-develop instance

magento-engcom-team · 2020-05-28T11:23:03Z

Hi @Den4ik. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team · 2020-05-28T11:24:22Z

Hi @Den4ik, here is your Magento instance.
Admin access: https://i-26984-2-4-develop.instances.magento-community.engineering/admin_075a
Login: 7baf676f Password: bb065eee9bb0
Instance will be terminated in up to 3 hours.

Den4ik · 2020-05-28T11:35:01Z

@magento run all tests

Den4ik · 2020-06-15T18:58:41Z

@magento give me 2.4-develop instance

magento-engcom-team · 2020-06-15T18:58:45Z

Hi @Den4ik. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team · 2020-06-15T19:00:19Z

Hi @Den4ik, here is your Magento instance.
Admin access: https://i-26984-2-4-develop.instances.magento-community.engineering/admin_e83e
Login: d0c01603 Password: 332a683b908a
Instance will be terminated in up to 3 hours.

Den4ik · 2020-10-24T00:25:23Z

@magento run all tests

Den4ik · 2020-10-24T01:44:55Z

@magento run all tests

Den4ik · 2020-10-24T08:16:34Z

@magento give me 2.4-develop instance

magento-deployment-service · 2020-10-24T08:16:35Z

Hi @Den4ik. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2020-10-24T08:20:42Z

Hi @Den4ik, here is your Magento Instance: https://f2d06cdb2237cbd8bafa352078a43b6f-2-4-develop.instances.magento-community.engineering
Admin access: https://f2d06cdb2237cbd8bafa352078a43b6f-2-4-develop.instances.magento-community.engineering/admin_115b
Login: ebc81b3b
Password: 156dd7bb0c9f

Den4ik · 2020-10-24T11:54:19Z

@magento run all tests

engcom-Foxtrot · 2020-11-19T14:31:03Z

Hello, @Den4ik. Please fix the MFTF test failures. We cant help you as we have no access to magenius-team repository.

Den4ik · 2020-11-19T20:33:35Z

Hello, @Den4ik. Please fix the MFTF test failures. We cant help you as we have no access to magenius-team repository.

Hi @engcom-Foxtrot I hope I'll have time on weekends

…gger-grid-reload-at-first-time

…om:magenius-team/magento2 into ftr/dont-trigger-grid-reload-at-first-time

Den4ik · 2020-11-26T12:27:18Z

@magento run Functional Tests CE

engcom-Foxtrot · 2020-12-08T11:01:02Z

Hello, @Den4ik. Are you going to continue with this PR?

Den4ik · 2020-12-08T11:55:15Z

Hello, @Den4ik. Are you going to continue with this PR?

Hi. Yep. I'm still in progress

Den4ik · 2020-12-16T21:02:25Z

@magento run all tests

…gger-grid-reload-at-first-time

Den4ik · 2020-12-16T21:07:29Z

@magento run all tests

…gger-grid-reload-at-first-time

Den4ik · 2020-12-23T12:08:29Z

@magento run all tests

engcom-Foxtrot · 2021-01-11T12:29:47Z

Hello, @Den4ik. Would you like to continue with this PR? We may close it due to inactivity.

Den4ik · 2021-01-11T19:20:49Z

Hi @engcom-Foxtrot Yes, I didn't have time to finish it due to my work, but I'm finally finishing this PR.

…gger-grid-reload-at-first-time

engcom-Foxtrot · 2021-01-26T10:15:03Z

Hello, @Den4ik. We should close this PR due to inactivity. Are you going to proceed with it?

engcom-Foxtrot · 2021-02-01T12:32:50Z

Hello, @Den4ik.
We are closing this PR as we have no write access to https://github.com/magenius-team/magento2.
We will continue with it in #31919. If you want to push some updates, please do it in #31919.

m2-assistant · 2021-02-01T12:33:07Z

Hi @Den4ik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

ghost added the Progress: pending review label Feb 23, 2020

magento-engcom-team added Area: Frontend Component: Ui Component: View Release Line: 2.4 labels Feb 23, 2020

Den4ik added the Progress: needs update label Feb 23, 2020

ghost removed the Progress: needs update label Feb 23, 2020

Den4ik changed the title ~~[Ui] Don't trigger grid reload at first page load~~ WIP: [Ui] Don't trigger grid reload at first page load Feb 23, 2020

Den4ik changed the title ~~WIP: [Ui] Don't trigger grid reload at first page load~~ [Ui] Don't trigger grid reload at first page load Mar 27, 2020

Den4ik force-pushed the ftr/dont-trigger-grid-reload-at-first-time branch from 5387569 to 6319618 Compare March 27, 2020 15:58

Den4ik changed the title ~~[Ui] Don't trigger grid reload at first page load~~ WIP: [Ui] Don't trigger grid reload at first page load Mar 27, 2020

sidolov added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Aug 14, 2020

Fix static tests

7d6bedb

Update customer address grid rendering logic

fe12c88

engcom-Foxtrot self-assigned this Nov 19, 2020

Den4ik added 2 commits November 26, 2020 14:51

Merge remote-tracking branch 'upstream/2.4-develop' into ftr/dont-tri…

b9fd45c

…gger-grid-reload-at-first-time

Merge branch 'ftr/dont-trigger-grid-reload-at-first-time' of github.c…

109477f

…om:magenius-team/magento2 into ftr/dont-trigger-grid-reload-at-first-time

Merge remote-tracking branch 'upstream/2.4-develop' into ftr/dont-tri…

3ecca50

…gger-grid-reload-at-first-time

Merge remote-tracking branch 'upstream/2.4-develop' into ftr/dont-tri…

b1f1a58

…gger-grid-reload-at-first-time

Merge remote-tracking branch 'upstream/2.4-develop' into ftr/dont-tri…

792ae14

…gger-grid-reload-at-first-time

engcom-Foxtrot mentioned this pull request Feb 1, 2021

magento/community-features#238: Don't trigger reload of ui listing at page load. #31919

Closed

4 tasks

engcom-Foxtrot closed this Feb 1, 2021

m2-community-project bot removed the Progress: needs update label Feb 1, 2021

[Ui] Don't trigger grid reload at first page load #26984

[Ui] Don't trigger grid reload at first page load #26984

Uh oh!

Conversation

Den4ik commented Feb 23, 2020 • edited by sivaschenko Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Pull Requests

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Feb 23, 2020

Uh oh!

Den4ik commented Feb 23, 2020

Uh oh!

magento-engcom-team commented Feb 23, 2020

Uh oh!

magento-engcom-team commented Feb 23, 2020

Uh oh!

Den4ik commented Feb 23, 2020

Uh oh!

magento-engcom-team commented Feb 23, 2020

Uh oh!

magento-engcom-team commented Feb 23, 2020

Uh oh!

ghost commented Feb 23, 2020

Uh oh!

Den4ik commented Mar 27, 2020

Uh oh!

magento-engcom-team commented Mar 27, 2020

Uh oh!

magento-engcom-team commented Mar 27, 2020

Uh oh!

Den4ik commented May 28, 2020

Uh oh!

magento-engcom-team commented May 28, 2020

Uh oh!

magento-engcom-team commented May 28, 2020

Uh oh!

Den4ik commented May 28, 2020

Uh oh!

Den4ik commented Jun 15, 2020

Uh oh!

magento-engcom-team commented Jun 15, 2020

Uh oh!

magento-engcom-team commented Jun 15, 2020

Uh oh!

Den4ik commented Oct 24, 2020

Uh oh!

Den4ik commented Oct 24, 2020

Uh oh!

Den4ik commented Oct 24, 2020

Uh oh!

magento-deployment-service bot commented Oct 24, 2020

Uh oh!

magento-deployment-service bot commented Oct 24, 2020

Uh oh!

Den4ik commented Oct 24, 2020

Uh oh!

engcom-Foxtrot commented Nov 19, 2020

Uh oh!

Den4ik commented Nov 19, 2020

Uh oh!

Den4ik commented Nov 26, 2020

Uh oh!

engcom-Foxtrot commented Dec 8, 2020

Uh oh!

Den4ik commented Dec 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Den4ik commented Dec 16, 2020

Uh oh!

Den4ik commented Dec 16, 2020

Uh oh!

Den4ik commented Dec 23, 2020

Uh oh!

engcom-Foxtrot commented Jan 11, 2021

Uh oh!

Den4ik commented Jan 11, 2021

Den4ik commented Feb 23, 2020 •

edited by sivaschenko

Loading

Den4ik commented Dec 8, 2020 •

edited

Loading