Skip to content

#26989 MFTF: Use <magentoCron> for reindex #26990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2020
Merged

#26989 MFTF: Use <magentoCron> for reindex #26990

merged 2 commits into from
Mar 10, 2020

Conversation

lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented Feb 23, 2020 •
edited by lenaorobei
Loading

Description (*)

Optimize Functional Tests performance by using <magentoCron groups="index"> where applicable.
Replace cache:flush with cache:flush config where applicable.,

Related Pull Requests

Fixed Issues (if relevant)

  1. MFTF: Use Magento Cron for reindexing after creating data #26989

Manual testing scenarios (*)

  1. CI Functional Tests should pass in < 70 minutes

Questions or comments

Work In Progress as I need to stabilise the CI.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 23, 2020

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ihor-sviziev ihor-sviziev mentioned this pull request Feb 28, 2020
Merged
4 tasks
@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

Failure not related to the scope of change, rather it's caused by other test running on the same instance:
image

@lbajsarowicz lbajsarowicz force-pushed the mftf/use-cron-reindex branch from 0fd1c4d to 3590b44 Compare March 1, 2020 19:25
@lbajsarowicz lbajsarowicz changed the title [WIP] #26989 MFTF: Use <magentoCron> for reindex and cache:flush with type #26989 MFTF: Use <magentoCron> for reindex and cache:flush with type Mar 1, 2020
@lbajsarowicz lbajsarowicz changed the title #26989 MFTF: Use <magentoCron> for reindex and cache:flush with type #26989 MFTF: Use <magentoCron> for reindex Mar 1, 2020
@lbajsarowicz lbajsarowicz mentioned this pull request Mar 1, 2020
Merged
4 tasks
@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

Rollback the huge changes and starting with little steps.

@lbajsarowicz
Copy link
Contributor Author

@magento run Functional Tests EE

image

Error not related to the change introduced.

@lbajsarowicz
Copy link
Contributor Author

@magento run Functional Tests EE, Integration Tests

@lenaorobei lenaorobei added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Mar 3, 2020
@ghost ghost assigned lenaorobei Mar 3, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-7026 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-7026 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Mar 4, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Charlie engcom-Charlie self-assigned this Mar 4, 2020
@magento-engcom-team magento-engcom-team mentioned this pull request Mar 10, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Mar 10, 2020
@lenaorobei
ENGCOM-7026: #26989 MFTF: Use <magentoCron> for reindex #26990
c9d6e35
@magento-engcom-team magento-engcom-team merged commit 8285a34 into magento:2.4-develop Mar 10, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 10, 2020

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenaorobei lenaorobei lenaorobei approved these changes

Assignees

@lenaorobei lenaorobei

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Bundle Component: Catalog Component: CatalogImportExport Component: CatalogInventory Component: CatalogRule Partner: Mediotype partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lbajsarowicz @magento-engcom-team @engcom-Alfa @lenaorobei @engcom-Charlie @sidolov