Skip to content

Fix issue with incorrect images custom attributes output in catalog module #27143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

arendarenko
Copy link
Contributor

@arendarenko arendarenko commented Mar 3, 2020

Description (*)

Commit f40f24c which was merged since Magento 2.3.3-p1 caused a regression issue with custom attributes on category pages because method getCustomAttributes can contains content like data-attr-value="some-attr-content" data-attr2-value="some-attr-content" so it's a bad idea to escape it.

My changes reverts those escapes.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 3, 2020

Hi @arendarenko. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

undo escaping of `getCustomAttributes` in phtml templates
@arendarenko arendarenko force-pushed the undo-custom-attributes-escape branch from 57c5af3 to dd607e6 Compare March 3, 2020 15:22
@ihor-sviziev ihor-sviziev self-assigned this Mar 3, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Mar 3, 2020
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @arendarenko,
Your changes looks good to me.
Could you cover your changes with integration tests in order not to make regression here in future?

@ihor-sviziev
Copy link
Contributor

Hi @arendarenko,
I'm closing this PR because described issue was already fixed in #26959 (in little bit different way), and this PR already merged.

Thank you for collaboration!

@m2-assistant
Copy link

m2-assistant bot commented Mar 19, 2020

Hi @arendarenko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants