-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix static test failures for class annotaions #27284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix static test failures for class annotaions #27284
Conversation
These checks were moved to Magento Coding Standards
Hi @ihor-sviziev. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Hi @lenaorobei, thank you for the review. |
Hi @dmytro-ch, thank you for the review. |
Notice: QA not applicable |
Failed functional tests not related to the changes in this PR |
Hi @ihor-sviziev, thank you for your contribution! |
Description (*)
I found that we have false positive static tests, example:

8ea9b0e
These checks were moved to Magento Coding Standards, so we don't need to have them.
In addition to that - removed class annotation is ok - magento/magento-coding-standard#171
CC @lenaorobei
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)