Skip to content

Fix zoom on search input #27506 #27603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ptylek
Copy link
Contributor

@ptylek ptylek commented Apr 4, 2020

Description (*)

When you click the search box, the browser zooms on the input. This happens on devices using Safari (tablet and mobile) and on both Blank and Luma theme.
This happens because the browser will zoom if the font-size is less than 16px.

The easiest fix is to use font-size of 16px instead of base 14px for that input.

Related Pull Requests

Fixed Issues (if relevant)

  1. Viewport resizing on search input focus on iphone #27506: Viewport resizing on search input focus on iphone

Manual testing scenarios (*)

  1. Click search icon
  2. Click search input
  3. With changes from this PR, the browser won't zoom on the input

Repeat for Blank and Luma theme.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 4, 2020

Hi @ptylek. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ptylek ptylek changed the title #27506 Fix zoom on search input Fix zoom on search input #27506 Apr 4, 2020
@miguelbalparda miguelbalparda self-assigned this Apr 6, 2020
@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-7289 has been created to process this Pull Request
✳️ @miguelbalparda, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@miguelbalparda miguelbalparda added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests and removed Auto-Tests: Covered All changes in Pull Request is covered by auto-tests labels Apr 9, 2020
@engcom-Alfa engcom-Alfa self-assigned this Apr 10, 2020
@engcom-Alfa
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Alfa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Alfa, here is your new Magento instance.
Admin access: https://pr-27603.instances.magento-community.engineering/admin_45a8
Login: 900ff395 Password: f6edd0458b54
Instance will be terminated in up to 3 hours.

Copy link
Contributor

@engcom-Alfa engcom-Alfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ptylek

Unfortunate, we are not able to reproduce the issue on the fresh 2.4-develop instance

Preconditions:
Luma theme
Safari browser
iPhone 6
OS v. 12.4.5

Actual Result:
ezgif com-video-to-gif

Or are we doing something wrong?
@ptylek Could you take a look?

Thanks!

@ptylek
Copy link
Contributor Author

ptylek commented Apr 10, 2020

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @ptylek. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @ptylek, here is your Magento instance.
Admin access: https://i-27603-2-4-develop.instances.magento-community.engineering/admin_5f70
Login: a0dd0067 Password: 0a467347abf2
Instance will be terminated in up to 3 hours.

@ptylek
Copy link
Contributor Author

ptylek commented Apr 10, 2020

@engcom-Alfa I think you used test instance based on PR changes. I just checked it on 2.4 vanilla test instance.

Preconditions:
Luma theme
Safari browser
iPhone 11
OS v. 13.3.1

RPReplay_Final1586526462

@engcom-Alfa
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Alfa. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Alfa, here is your Magento instance.
Admin access: https://i-27603-2-4-develop.instances.magento-community.engineering/admin_be19
Login: 444138f2 Password: 9a4c7ad3d1d0
Instance will be terminated in up to 3 hours.

@engcom-Alfa
Copy link
Contributor

engcom-Alfa commented Apr 13, 2020

✔️ QA Passed

Go to Storefront -> 🔍

Before:
ezgif com-video-to-gif (1)

After:
ezgif com-video-to-gif
The same results and on blank theme

@engcom-Echo engcom-Echo self-assigned this Apr 13, 2020
@VladimirZaets VladimirZaets added this to the 2.4.0 milestone Apr 14, 2020
@VladimirZaets VladimirZaets added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Apr 14, 2020
@magento-engcom-team magento-engcom-team merged commit ebe7aec into magento:2.4-develop Apr 16, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 16, 2020

Hi @ptylek, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Event: Global-Contribution-Day Partner: creativestyle partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants