-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix zoom on search input #27506 #27603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix zoom on search input #27506 #27603
Conversation
Hi @ptylek. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Hi @miguelbalparda, thank you for the review.
|
@magento give me test instance |
Hi @engcom-Alfa. Thank you for your request. I'm working on Magento instance for you |
Hi @engcom-Alfa, here is your new Magento instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@magento give me 2.4-develop instance |
Hi @ptylek. Thank you for your request. I'm working on Magento 2.4-develop instance for you |
Hi @ptylek, here is your Magento instance. |
@engcom-Alfa I think you used test instance based on PR changes. I just checked it on 2.4 vanilla test instance. Preconditions: |
@magento give me 2.4-develop instance |
Hi @engcom-Alfa. Thank you for your request. I'm working on Magento 2.4-develop instance for you |
Hi @engcom-Alfa, here is your Magento instance. |
Hi @ptylek, thank you for your contribution! |
Description (*)
When you click the search box, the browser zooms on the input. This happens on devices using Safari (tablet and mobile) and on both Blank and Luma theme.
This happens because the browser will zoom if the font-size is less than 16px.
The easiest fix is to use font-size of 16px instead of base 14px for that input.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Repeat for Blank and Luma theme.
Questions or comments
Contribution checklist (*)