Allows JSON unserializing to be associative or object

[jajajaime]

Description (*)

Allows a developer to pass an optional boolean argument when unserializing a JSON string, so it can be returned as object or associative. Keeps associative as default for backwards compatibility.

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

1. Create code that unserializes json string while passing the extra argument of false

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @jajajaime. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[ihor-sviziev]

I remember we had some architecture discussions in magento/architecture#254, magento/magento-coding-standard#91 and previously in magento/architecture#161.

AFAIK no real decision was done yet. @lenaorobei do we have any updates on that?

[orlangur]

Such change is not allowed: https://devdocs.magento.com/guides/v2.3/contributor-guide/backward-compatible-development/

Let's first find out whether we need such functionality at all.

[ihor-sviziev]

@orlangur please explain why you moved this PR to "on hold" status.

[lenaorobei]

Unfortunately, we cannot accept this PR since it violates backward compatibility policy.

There were some discussions regarding introduction new JSON contract, but there is no resolution yet. Please see details here magento/architecture#254

[m2-assistant]

Hi @jajajaime, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[jajajaime]

@lenaorobei is this because of "Adding parameters in public methods"? If so, I think it should be on a case by case basis, as creating a new class or interface would create more work for devs to switch to the new one in this case.

[orlangur]

@jajajaime backward compatibility policy is mandatory, no exception.

when unserializing a JSON string, so it can be returned as object or associative

Please create a proposal in architecture repo first to describe why it needs to be returned as object.