Skip to content

Replaced deprecated method addError with addErrorMessage #28349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

VinothKumar361
Copy link
Contributor

Description (*)

This Pull request replaces the deprecated addError method with addErrorMessage method

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented May 24, 2020

Hi @VinothKumar361. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@VinothKumar361
Copy link
Contributor Author

@magento run all tests

@ihor-sviziev ihor-sviziev self-assigned this May 25, 2020
@ihor-sviziev ihor-sviziev removed their assignment May 25, 2020
@edenduong edenduong self-assigned this May 25, 2020
@edenduong
Copy link
Contributor

@magento run all tests

@edenduong
Copy link
Contributor

Hi @VinothKumar361 : Could you please check the static tests? Thank you !

Copy link
Contributor

@edenduong edenduong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Please fix the static test.

@m2-assistant
Copy link

m2-assistant bot commented Jun 13, 2020

Hi @VinothKumar361, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@VinothKumar361 VinothKumar361 deleted the Replaced_deprecated_addError_function branch June 13, 2020 14:27
@VinothKumar361 VinothKumar361 restored the Replaced_deprecated_addError_function branch June 13, 2020 14:27
@VinothKumar361 VinothKumar361 deleted the Replaced_deprecated_addError_function branch June 13, 2020 14:27
@VinothKumar361 VinothKumar361 restored the Replaced_deprecated_addError_function branch June 13, 2020 14:27
Copy link
Contributor

@engcom-Alfa engcom-Alfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @VinothKumar361 . During testing, we faced the issue.

Manual testing scenario:

  1. Create customer and subscribe to newsletters;
  2. Go to Admin -> Marketing -> Newsletter Subscribers;
  3. Select the subscriber's checkbox;
  4. Select Unsubscribe from the dropdown mass action menu;
  5. Click on Submit button;

Actual Result: ✖️ 404 error message received

Peek 2020-08-11 11-24

@VinothKumar361 Could you take a look?

Thanks!

@ghost ghost dismissed edenduong’s stale review August 11, 2020 08:39

Pull Request state was updated. Re-review required.

@engcom-Echo
Copy link
Contributor

Hi @engcom-Alfa, the bug fixed. Thank you.

@engcom-Echo engcom-Echo requested a review from edenduong August 11, 2020 13:03
@engcom-Echo
Copy link
Contributor

Hi @edenduong. Please approve again to deliver the PR for testing. Thanks.

@engcom-Echo
Copy link
Contributor

@magento run all tests

@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Aug 17, 2020
@engcom-Echo engcom-Echo force-pushed the Replaced_deprecated_addError_function branch from 4d7c2f1 to 234e1ac Compare September 2, 2020 14:25
@engcom-Echo
Copy link
Contributor

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-7951 has been created to process this Pull Request

@m2-assistant
Copy link

m2-assistant bot commented Sep 7, 2020

Hi @VinothKumar361, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Cleanup Component: Customer Component: Downloadable Component: ImportExport Component: Indexer Component: Integration Component: Multishipping Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants