-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Replaced deprecated method addError with addErrorMessage #28349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced deprecated method addError with addErrorMessage #28349
Conversation
Hi @VinothKumar361. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. |
@magento run all tests |
@magento run all tests |
Hi @VinothKumar361 : Could you please check the static tests? Thank you ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. Please fix the static test.
Hi @VinothKumar361, thank you for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @VinothKumar361 . During testing, we faced the issue.
Manual testing scenario:
- Create customer and subscribe to newsletters;
- Go to Admin -> Marketing -> Newsletter Subscribers;
- Select the subscriber's checkbox;
- Select Unsubscribe from the dropdown mass action menu;
- Click on Submit button;
Actual Result: ✖️ 404 error message received
@VinothKumar361 Could you take a look?
Thanks!
Pull Request state was updated. Re-review required.
Hi @engcom-Alfa, the bug fixed. Thank you. |
Hi @edenduong. Please approve again to deliver the PR for testing. Thanks. |
@magento run all tests |
4d7c2f1
to
234e1ac
Compare
@magento run all tests |
Hi @sidolov, thank you for the review. |
Hi @VinothKumar361, thank you for your contribution! |
Description (*)
This Pull request replaces the deprecated addError method with addErrorMessage method
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)