Set of improvements for LoginAsCustomer modules

[lbajsarowicz]

Description (*)

PR contains a set of improvements for LoginAsCustomer modules.

• Replaced around plugin with after
• Removed redundant code
• Correctly used isSetFlag instead of (bool)->getValue()

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Set of improvements for LoginAsCustomer modules #29689: Set of improvements for LoginAsCustomer modules

[m2-assistant]

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[lbajsarowicz]

@magento run all tests

[sidolov]

@magento create issue

[ihor-sviziev]

@lbajsarowicz please review & fix static tests.

[lbajsarowicz]

@magento run Static Tests

@ihor-sviziev What I find amusing in this notification is that it enforces introducing arguments that are not necessary, so it also couples the Plugin to the interface that it is attached to, even if it's not necessary at all.

[ihor-sviziev]

@ihor-sviziev What I find amusing in this notification is that it enforces introducing arguments that are not necessary, so it also couples the Plugin to the interface that it is attached to, even if it's not necessary at all.

Agree. Could you report it as separate issue?

[ihor-sviziev]

Failing static test is false positive as Exception is not \Exception in this case, it's imported on the top of the file.
Just created issue on that magento/magento-coding-standard#194

@magento run all tests

[lbajsarowicz]

@magento run all tests

Put an alias on the Exception

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8052 has been created to process this Pull Request

[engcom-Delta]

✔️ QA passed
Was checked Login as Customer is enabled by default, disable extension, login as customer with Auto Detection/Manual Selection, login as customer from order view, invoice view, ship view and credit memo view pages
enable/disable Allow remote shopping assistance option for customer in backend/frontend

[engcom-Delta]

Note: Automation tests are passed

[m2-assistant]

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.