#29704 :- Submit search button in form-mini should be disabled until minimum search length is reached

[konarshankar07]

Description (*)

This PR will fix the issue with the submit search button is not respecting the minimum search length

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Submit search button in form-mini should be disabled until minimum search length is reached #29704

Manual testing scenarios (*)

1. Focus on form-mini search box.
2. Type one or two alphanumeric characters in search box.

Expected Result

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @konarshankar07. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[konarshankar07]

@magento run all tests

[rogyar]

@magento give me test instance

[magento-engcom-team]

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-29724.instances.magento-community.engineering/admin_34a9
Login: ab5342ec Password: 6759de2048d1
Instance will be terminated in up to 3 hours.

[rogyar]

Hi @konarshankar07. Thank you for the fix.

I'm just curious, how hard do you think will be to spread the same fix for the submit by "return" button? With your fix, the button stays disabled but it's still possible to submit the search query by pressing the "return" button. If this part of the fix will be complicated, feel free to create a separate PR. If the mentioned fix is easy to implement, it would be great to have it as a part of this PR.

In any case, I would ask you to cover this fix by a simple MFTF test.

Thank you!

[konarshankar07]

@magento run all tests

[gabrieldagama]

Hi @konarshankar07, thanks for the pull request, it looks great! Please follow some small suggestions below:

[konarshankar07]

@magento run all tests

[gabrieldagama]

Thanks for the updates @konarshankar07. The failed tests aren't related to this PR.

[magento-engcom-team]

Hi @gabrieldagama, thank you for the review.
ENGCOM-8067 has been created to process this Pull Request

[konarshankar07]

Thanks @gabrieldagama for the review
Can you please remove the Auto-test: Not covered label?

[gabrieldagama]

@magento run Functional Tests CE

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-8067 has been created to process this Pull Request

[engcom-Oscar]

✔️ QA Passed

Preconditions:

1. Magento 2.4-develop installed.
2. Open Home page on frontend.

Steps to reproduce :

1. Go to quick search input field.
2. Type one or two alphanumeric (less then minimum required) characters in search field and verify 'Submit' button (magnifying glass)

Before ✖️

• Submit button (magnifying glass) becomes enabled even if minimum search length is not reached:

After ✔️

• Submit button (magnifying glass)remains disabled until minimum search length is reached:

[engcom-Echo]

@magento run all tests

[konarshankar07]

@magento run WebAPI Tests

[m2-assistant]

Hi @konarshankar07, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.